Skip to content

Commit

Permalink
[MINOR][CORE] Cleanup unused vals in DAGScheduler.handleTaskCompletion
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?

Cleanup unused vals in `DAGScheduler.handleTaskCompletion` to reduce the code complexity slightly.

## How was this patch tested?

Existing test cases.

Author: Xingbo Jiang <[email protected]>

Closes #21406 from jiangxb1987/handleTaskCompletion.
  • Loading branch information
jiangxb1987 authored and cloud-fan committed May 24, 2018
1 parent 486ecc6 commit e108f84
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1167,9 +1167,7 @@ class DAGScheduler(
*/
private[scheduler] def handleTaskCompletion(event: CompletionEvent) {
val task = event.task
val taskId = event.taskInfo.id
val stageId = task.stageId
val taskType = Utils.getFormattedClassName(task)

outputCommitCoordinator.taskCompleted(
stageId,
Expand Down Expand Up @@ -1323,7 +1321,7 @@ class DAGScheduler(
"tasks in ShuffleMapStages.")
}

case FetchFailed(bmAddress, shuffleId, mapId, reduceId, failureMessage) =>
case FetchFailed(bmAddress, shuffleId, mapId, _, failureMessage) =>
val failedStage = stageIdToStage(task.stageId)
val mapStage = shuffleIdToMapStage(shuffleId)

Expand Down Expand Up @@ -1411,7 +1409,7 @@ class DAGScheduler(
}
}

case commitDenied: TaskCommitDenied =>
case _: TaskCommitDenied =>
// Do nothing here, left up to the TaskScheduler to decide how to handle denied commits

case _: ExceptionFailure | _: TaskKilled =>
Expand Down

0 comments on commit e108f84

Please sign in to comment.