[PySpark] Fix typo in comments in PySpark's udf() definition #20158
Conversation
rednaxelafx
changed the title
|
OK. Have a look for more typos while you're at it. We try to avoid whole PRs just to fix each one. |
|
Test build #85700 has finished for PR 20158 at commit
|
|
@srowen Thanks for your review! I'll have a look at other typos and update this PR later. I was actually working on code around this place and thought I'd split out the typo fix to make it cleaner to review. Yes I totally agree it's a good idea to clean up more than one typo in a single PR. |
|
You can just combine small-scale fixes to the surrounding code in the main PR then. I think that's fine. |
|
There's a same typo in |
|
let's get them fixed for 2.3? |
|
Ping @rednaxelafx |
|
@rednaxelafx, can you fix the one in |
|
@rednaxelafx, I was fixing some codes around UDF. I included the current typo in #20288. I think you could close this one. |
|
@HyukjinKwon cool! Thanks a lot for including it! Closing this one now. |
… and Catalog in PySpark ## What changes were proposed in this pull request? This PR proposes to deprecate `register*` for UDFs in `SQLContext` and `Catalog` in Spark 2.3.0. These are inconsistent with Scala / Java APIs and also these basically do the same things with `spark.udf.register*`. Also, this PR moves the logcis from `[sqlContext|spark.catalog].register*` to `spark.udf.register*` and reuse the docstring. This PR also handles minor doc corrections. It also includes #20158 ## How was this patch tested? Manually tested, manually checked the API documentation and tests added to check if deprecated APIs call the aliases correctly. Author: hyukjinkwon <[email protected]> Closes #20288 from HyukjinKwon/deprecate-udf. (cherry picked from commit 39d244d) Signed-off-by: Takuya UESHIN <[email protected]>
… and Catalog in PySpark ## What changes were proposed in this pull request? This PR proposes to deprecate `register*` for UDFs in `SQLContext` and `Catalog` in Spark 2.3.0. These are inconsistent with Scala / Java APIs and also these basically do the same things with `spark.udf.register*`. Also, this PR moves the logcis from `[sqlContext|spark.catalog].register*` to `spark.udf.register*` and reuse the docstring. This PR also handles minor doc corrections. It also includes #20158 ## How was this patch tested? Manually tested, manually checked the API documentation and tests added to check if deprecated APIs call the aliases correctly. Author: hyukjinkwon <[email protected]> Closes #20288 from HyukjinKwon/deprecate-udf.
What changes were proposed in this pull request?
Just a simple typo fix from
curcuitingtocircuiting.How was this patch tested?
N/A. This patch does not change any code behavior.