[SPARK-13747][SQL] Fix concurrent query with fork-join pool #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Test build #52687 has finished for PR 11586 at commit
|
| try { | ||
| // Should not throw IllegalArgumentException | ||
| (1 to 100).par.foreach { _ => | ||
| sc.parallelize(1 to 5).map { i => (i, i) }.toDF("a", "b").count() |
|
Test build #52772 has finished for PR 11586 at commit
|
|
Merging to master |
| @@ -613,7 +613,12 @@ class DAGScheduler( | |||
| properties: Properties): Unit = { | |||
| val start = System.nanoTime | |||
| val waiter = submitJob(rdd, func, partitions, callSite, resultHandler, properties) | |||
| Await.ready(waiter.completionFuture, atMost = Duration.Inf) | |||
| // Note: Do not call Await.ready(future) because that calls `scala.concurrent.blocking`, | |||
There was a problem hiding this comment.
BlockManager#doPut() does this on line 891:
Await.ready(replicationFuture, Duration.Inf)
Should that be replaced as well ?
There was a problem hiding this comment.
No necessary. The issue here is because the ThreadLocal properties doesn't work well with ForkJoinPool. A new task may see some ThreadLocal properties from other task since they are using the same thread.
Does BlockManager use ThreadLocal?
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Fix this use case, which was already fixed in SPARK-10548 in 1.6 but was broken in master due to apache#9264: ``` (1 to 100).par.foreach { _ => sc.parallelize(1 to 5).map { i => (i, i) }.toDF("a", "b").count() } ``` This threw `IllegalArgumentException` consistently before this patch. For more detail, see the JIRA. ## How was this patch tested? New test in `SQLExecutionSuite`. Author: Andrew Or <[email protected]> Closes apache#11586 from andrewor14/fix-concurrent-sql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix this use case, which was already fixed in SPARK-10548 in 1.6 but was broken in master due to #9264:
This threw
IllegalArgumentExceptionconsistently before this patch. For more detail, see the JIRA.How was this patch tested?
New test in
SQLExecutionSuite.