Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only count 5xx as error in Envoy ALS receiver #7111

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Only count 5xx as error in Envoy ALS receiver #7111

merged 2 commits into from
Jun 11, 2021

Conversation

kezhenxu94
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@kezhenxu94 kezhenxu94 added the backend OAP backend related. label Jun 11, 2021
@kezhenxu94 kezhenxu94 added this to the 8.7.0 milestone Jun 11, 2021
@kezhenxu94 kezhenxu94 requested a review from wu-sheng June 11, 2021 12:26
wu-sheng
wu-sheng previously approved these changes Jun 11, 2021
@wu-sheng wu-sheng added the enhancement Enhancement on performance or codes label Jun 11, 2021
@wu-sheng
Copy link
Member

FYI to other readers, 4xx include 404 and 403, which typically are caused by the client-side issue.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #7111 (61cbf12) into master (eace27e) will decrease coverage by 30.51%.
The diff coverage is 1.04%.

❗ Current head 61cbf12 differs from pull request most recent head 5289dec. Consider uploading reports for the commit 5289dec to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7111       +/-   ##
=============================================
- Coverage     58.84%   28.33%   -30.52%     
=============================================
  Files          1016     1761      +745     
  Lines         25951    37288    +11337     
  Branches       2555     4936     +2381     
=============================================
- Hits          15272    10567     -4705     
- Misses         9336    25727    +16391     
+ Partials       1343      994      -349     
Impacted Files Coverage Δ
...ver/analyzer/provider/jvm/JVMSourceDispatcher.java 0.00% <0.00%> (-97.92%) ⬇️
...zer/agent/kafka/provider/KafkaFetcherProvider.java 29.16% <0.00%> (-57.79%) ⬇️
...er/receiver/envoy/als/LogEntry2MetricsAdapter.java 49.09% <0.00%> (+49.09%) ⬆️
...erver/receiver/jvm/provider/JVMModuleProvider.java 0.00% <0.00%> (-100.00%) ⬇️
...rovider/handler/JVMMetricReportServiceHandler.java 0.00% <0.00%> (-80.00%) ⬇️
...gent/kafka/provider/handler/JVMMetricsHandler.java 74.28% <100.00%> (ø)
...he/skywalking/oal/rt/output/DispatcherContext.java 0.00% <0.00%> (-100.00%) ⬇️
...skywalking/oal/rt/output/AllDispatcherContext.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/skywalking/oap/server/core/source/Source.java 0.00% <0.00%> (-100.00%) ⬇️
...che/skywalking/oap/server/core/source/Service.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1781 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3355f...5289dec. Read the comment docs.

@wu-sheng wu-sheng merged commit efcb396 into master Jun 11, 2021
@wu-sheng wu-sheng deleted the als/status branch June 11, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. enhancement Enhancement on performance or codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants