Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format all HTTP related operation name in METHOD:URI #7135

Closed
wu-sheng opened this issue Jun 20, 2021 · 4 comments
Closed

Format all HTTP related operation name in METHOD:URI #7135

wu-sheng opened this issue Jun 20, 2021 · 4 comments
Assignees
@wankai123
Labels
agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Milestone
Java - 8.8.0

Comments

@wu-sheng
Copy link
Member

@wankai123 Due to #7130, we should adjust all Java related plugin, and make sure the format is correct. And we should update plugin dev doc about this.

All @apache/skywalking-committers, other language agents should take care of this too.
@wu-sheng wu-sheng added agent Language agent related. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. enhancement Enhancement on performance or codes labels Jun 20, 2021
@wu-sheng wu-sheng added this to the 8.7.0 milestone Jun 20, 2021
@kezhenxu94
Copy link
Member

Should also only count response code 5xx as errors?

#7111

@wu-sheng
Copy link
Member Author

Should also only count response code 5xx as errors?

#7111

We should count that as an error at the client side, but that is a different context. This issue is relating to operation name because OpenAPI spec support.

@wu-sheng wu-sheng modified the milestones: 8.7.0, 8.8.0 Jul 27, 2021
@wu-sheng wu-sheng mentioned this issue Aug 4, 2021
Closed
1 task
@wu-sheng
Copy link
Member Author

wu-sheng commented Sep 3, 2021

@wankai123 After you finish the group dynamic configuration, you could take care of this. We should have several weeks before cut 8.8.0 release, because there will a long testing about our new Elastic client implementation.

@wu-sheng wu-sheng modified the milestones: 8.8.0, Java - 8.8.0 Sep 7, 2021
@wu-sheng
Copy link
Member Author

wu-sheng commented Sep 7, 2021

@wankai123 I just moved the milestone, due to Java agent moved out of main repo.

@wankai123 wankai123 mentioned this issue Sep 25, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wankai123 wankai123

Labels
agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Milestone
Java - 8.8.0
Development

No branches or pull requests
3 participants
@wu-sheng @kezhenxu94 @wankai123