Format Springmvc & Tomcat EntrySpan operation name to METHOD:URI
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Sep 25, 2021
CHANGES.md
Outdated
| @@ -28,6 +28,7 @@ Release Notes. | |||
| * Implement Kafka Log Reporter. Add config item of `agnt.conf`, `plugin.kafka.topic_logging`. | |||
| * Upgrade byte-buddy to 1.11.18 | |||
| * Add plugin to support Apache HttpClient 5. | |||
| * Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI` | |||
There was a problem hiding this comment.
Suggested change
| * Format Springmvc & Tomcat EntrySpan operation name to `METHOD:URI` | |
| * Format SpringMVC & Tomcat EntrySpan operation name to `METHOD:URI` | |
| * Make `HTTP method` in the operation name according to runtime, rather than previous code-level definition, which used to have possibilities including multiple HTTP methods. |
There was a problem hiding this comment.
@wankai123 You missed my second one.
|
You missed UT parts :) |
wu-sheng
approved these changes
Sep 26, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format Springmvc & Tomcat EntrySpan operation name to
METHOD:URIIf this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.related to apache/skywalking#7135
clean up
operationIdinexpectedData.yamlbecause not use anymore.