support select '' as a from order #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristaZero
requested changes
Jul 31, 2020
There was a problem hiding this comment.
Hi @cmonkey Thanks for your issue and PR. Welcome to be our contributor!
Could you look at my comments to perfect this PR?
| @@ -34,5 +34,9 @@ | |||
| <artifactId>shardingsphere-sql-parser-spi</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.google.guava</groupId> | |||
...ql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SQLUtil.java
Show resolved
Hide resolved
|
@cmonkey Hi thanks for rapid change.
|
ok |
cmonkey
force-pushed
the
fix-getParenthesesOffset-method
branch
from
f5d78c0 to
f8afa6c
Compare
tristaZero
requested changes
Jul 31, 2020
tristaZero
approved these changes
Jul 31, 2020
Lucas-307
pushed a commit
to Lucas-307/shardingsphere
that referenced
this pull request
Aug 3, 2020
kimmking
added a commit
that referenced
this pull request
Aug 3, 2020
* Visit CreateDataSourcesStatement * add setter * Modify interface for DatabaseTypes * add insert select and replace select statement doc (#6521) * add insert select statement doc * add replace select statement doc * modify doc description * Fix #3954 : Sharding-JDBC querying support PostgreSQL array type (#6524) * Sharding-JDBC support PostgreSQL array type * Sharding-JDBC support PostgreSQL array type * Sharding-JDBC support PostgreSQL array type, try to fix ci error * check style * Refactor sqlStatement context converter * Rename ProxyConfigurationLoader (#6540) * refactor OrchestrationShardingSphereDataSource * refactor OrchestrationShardingSphereDataSource * refactor OrchestrationShardingSphereDataSource * Rename ProxyConfigurationLoader * Refactor ProxyConfigurationLoader * Refactor ProxyConfigurationConverter * Fix javadoc * Fix javadoc * Refactor OrchestrationShardingSphereDataSource * Refactor OrchestrationShardingSphereDataSource * #6294 oracle support select for update (#6538) * #6527, parameters for transparent mode (#6545) * #6527, parameters for transparent mode * #6527, refine * update release guide of elasticjob (#6549) * support select '' as a from order (#6542) * Adjust executor and engine package directory (#6552) * Create ShardingSphereSQLParserEngine and factory (#6553) * Adjust sql engine package dir (#6554) * Add BootstrapArguments (#6555) * Refactor ProxyConfigurationConverterFactory * Refactor ProxyConfigurationLoader * Adjust private method order of Bootstrap * Add BootstrapArguments * use ShardingSphereSQLParserEngine instead of SQLParserEngine (#6557) * Refactor Bootstrap's log (#6559) * Refactor Bootstrap * Refactor Bootstrap's log * fix docs (#6560) * Remove ProxyConfigurationConverter (#6564) * rename Bootstrap.init * Refactor Bootstrap.log * Remove useless javadoc * Add final * Revise ProxyConfiguration * Revise DataSourceParameter * Revise DataSourceParameter * Refactor OrchestrationConfigurationConverter * Add OrchestrationBootstrap * Add YamlProxyConfigurationSwapper * Remove ProxyConfigurationConverter * Refactor Bootstrap * Refactor Bootstrap * Refactor Bootstrap * Remove Serializable for ProxyConfiguration * refactor OrchestrationBootstrap * For checkstyle * Add orchestrationEnabled for Bootstrap (#6565) * Refactor Bootstrap * Add orchestrationEnabled for Bootstrap * update release guide about docker (#6566) * docker release guide for elasticjob (#6567) * docker release for elasticjob * docker release guide for elasticjob ui * Create maven.yml (#6563) * Remove ShardingSphereSchema.dataSourceParameters (#6569) * Decouple ShardingSphereSchema.dataSourceParameters * Remove ShardingSphereSchema.dataSourceParameters * Add ProxyDataSourceContext * Refactor SchemaContextsBuilder * Visit CreateDataSourcesStatement * Adjust executor and engine package directory (#6552) * Adjust sql engine package dir (#6554) * Adjust executor and engine package directory (#6552) * Adjust sql engine package dir (#6554) * Adjust executor and engine package directory (#6552) * Adjust sql engine package dir (#6554) * Rename "unfinish" to "unfinished"(#6571) * Rename "unfinish" to "unfinished"(#6571) Co-authored-by: tristaZero <[email protected]> Co-authored-by: DuanZhengqiang <[email protected]> Co-authored-by: sandynz <[email protected]> Co-authored-by: Liang Zhang <[email protected]> Co-authored-by: zangyk <[email protected]> Co-authored-by: Zhang Yonglun <[email protected]> Co-authored-by: cmonkey <[email protected]> Co-authored-by: Juan Pan(Trista) <[email protected]> Co-authored-by: kimmking <[email protected]> Co-authored-by: qiulu3 <Lucas209910>
cmonkey
added a commit
to cmonkey/shardingsphere
that referenced
this pull request
Aug 18, 2020
cmonkey
added a commit
to cmonkey/shardingsphere
that referenced
this pull request
Aug 18, 2020
cmonkey
added a commit
to cmonkey/shardingsphere
that referenced
this pull request
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6541
Changes proposed in this pull request: