Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shardingjdbc 4.1.1 mysql sql parse support "for update", but oracle not support #6294

Closed
zangyk opened this issue Jul 7, 2020 · 5 comments · Fixed by #6538
Closed

shardingjdbc 4.1.1 mysql sql parse support "for update", but oracle not support #6294

zangyk opened this issue Jul 7, 2020 · 5 comments · Fixed by #6538
Assignees
@zangyk
Labels
in: SQL parse type: bug
Milestone
5.0.0-alpha

Comments

@zangyk
Copy link
Contributor

zangyk commented Jul 7, 2020

shardingjdbc 4.1.1 mysql sql parse support "for update", but oracle not support
@tristaZero
Copy link
Contributor

@zangyk Yep, right. But it is not so difficult to parse this SQL for Oracle. If you would like to take part in, here is a solution needing your contribution.

Add the grammar definition fo this SQL to shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DMLStatement.g4 referring Oracle documment.

Look forward to your joining.

@zangyk
Copy link
Contributor Author

zangyk commented Jul 9, 2020

I want to submit some code，how should I do？

@tristaZero
Copy link
Contributor

Hi welcome @zangyk !
As I said before,

Add the grammar definition fo this SQL to shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DMLStatement.g4 referring Oracle documment.

Do you have any ideas about that? Currently, I reopened this issue and assigned it to you.
If you want to know the process of the contribution to this community, please refer to Contribution guidence

@tristaZero tristaZero reopened this Jul 10, 2020
@tristaZero tristaZero added this to the 5.0.0 milestone Jul 10, 2020
@zangyk
Copy link
Contributor Author

zangyk commented Jul 29, 2020

I solved this issues, but when I pushed a new branch to GitHub, I was prompted that I didn't have permission。

@tristaZero
Copy link
Contributor

tristaZero commented Jul 30, 2020 •
edited
Loading

Hi @zangyk
I appreciated your effort.
It is expected to raize a PR for your change, Contriubtor guide will give you more detail.
Waiting for your joining!

zangyk added a commit to zangyk/shardingsphere that referenced this issue Jul 30, 2020
@zangyk
apache#6294 oracle support select for update
e5b5858
@zangyk zangyk mentioned this issue Jul 30, 2020
Merged
zangyk added a commit to zangyk/shardingsphere that referenced this issue Jul 30, 2020
@zangyk
Merge pull request #2 from zangyk/apache#6294
b3f8142 
apache#6294 oracle support select  for update
tristaZero pushed a commit that referenced this issue Jul 31, 2020
@zangyk
#6294 oracle support select for update (#6538)
fe9734d
Lucas-307 pushed a commit to Lucas-307/shardingsphere that referenced this issue Aug 3, 2020
@zangyk
apache#6294 oracle support select for update (apache#6538)
efe9b2f
kimmking added a commit that referenced this issue Aug 3, 2020
@Lucas-307 @tristaZero
@strongduanmu @sandynz @terrymanu @zangyk @tuohai666 @cmonkey @kimmking
Rename "unfinish" to "unfinished" (#6582)
b47eb4c 
* Visit CreateDataSourcesStatement

* add setter

* Modify interface for DatabaseTypes

* add insert select and replace select statement doc (#6521)

* add insert select statement doc

* add replace select statement doc

* modify doc description

* Fix #3954 : Sharding-JDBC querying support PostgreSQL array type (#6524)

* Sharding-JDBC support PostgreSQL array type

* Sharding-JDBC support PostgreSQL array type

* Sharding-JDBC support PostgreSQL array type, try to fix ci error

* check style

* Refactor sqlStatement context converter

* Rename ProxyConfigurationLoader (#6540)

* refactor OrchestrationShardingSphereDataSource

* refactor OrchestrationShardingSphereDataSource

* refactor OrchestrationShardingSphereDataSource

* Rename ProxyConfigurationLoader

* Refactor ProxyConfigurationLoader

* Refactor ProxyConfigurationConverter

* Fix javadoc

* Fix javadoc

* Refactor OrchestrationShardingSphereDataSource

* Refactor OrchestrationShardingSphereDataSource

* #6294 oracle support select  for update (#6538)

* #6527, parameters for transparent mode (#6545)

* #6527, parameters for transparent mode

* #6527, refine

* update release guide of  elasticjob (#6549)

* support select '' as a from order (#6542)

* Adjust executor and engine package directory (#6552)

* Create ShardingSphereSQLParserEngine and factory (#6553)

* Adjust sql engine package dir (#6554)

* Add BootstrapArguments (#6555)

* Refactor ProxyConfigurationConverterFactory

* Refactor ProxyConfigurationLoader

* Adjust private method order of Bootstrap

* Add BootstrapArguments

* use ShardingSphereSQLParserEngine instead of SQLParserEngine (#6557)

* Refactor Bootstrap's log (#6559)

* Refactor Bootstrap

* Refactor Bootstrap's log

* fix docs (#6560)

* Remove ProxyConfigurationConverter (#6564)

* rename Bootstrap.init

* Refactor Bootstrap.log

* Remove useless javadoc

* Add final

* Revise ProxyConfiguration

* Revise DataSourceParameter

* Revise DataSourceParameter

* Refactor OrchestrationConfigurationConverter

* Add OrchestrationBootstrap

* Add YamlProxyConfigurationSwapper

* Remove ProxyConfigurationConverter

* Refactor Bootstrap

* Refactor Bootstrap

* Refactor Bootstrap

* Remove Serializable for ProxyConfiguration

* refactor OrchestrationBootstrap

* For checkstyle

* Add orchestrationEnabled for Bootstrap (#6565)

* Refactor Bootstrap

* Add orchestrationEnabled for Bootstrap

* update release guide about docker (#6566)

* docker release guide for elasticjob (#6567)

* docker release for elasticjob

* docker release guide for elasticjob ui

* Create maven.yml (#6563)

* Remove ShardingSphereSchema.dataSourceParameters (#6569)

* Decouple ShardingSphereSchema.dataSourceParameters

* Remove ShardingSphereSchema.dataSourceParameters

* Add ProxyDataSourceContext

* Refactor SchemaContextsBuilder

* Visit CreateDataSourcesStatement

* Adjust executor and engine package directory (#6552)

* Adjust sql engine package dir (#6554)

* Adjust executor and engine package directory (#6552)

* Adjust sql engine package dir (#6554)

* Adjust executor and engine package directory (#6552)

* Adjust sql engine package dir (#6554)

* Rename "unfinish" to "unfinished"(#6571)

* Rename "unfinish" to "unfinished"(#6571)

Co-authored-by: tristaZero <[email protected]>
Co-authored-by: DuanZhengqiang <[email protected]>
Co-authored-by: sandynz <[email protected]>
Co-authored-by: Liang Zhang <[email protected]>
Co-authored-by: zangyk <[email protected]>
Co-authored-by: Zhang Yonglun <[email protected]>
Co-authored-by: cmonkey <[email protected]>
Co-authored-by: Juan Pan(Trista) <[email protected]>
Co-authored-by: kimmking <[email protected]>
Co-authored-by: qiulu3 <Lucas209910>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zangyk zangyk

Labels
in: SQL parse type: bug
Projects
None yet
Milestone
5.0.0-alpha
Development

Successfully merging a pull request may close this issue.

#6294 zangyk/shardingsphere
3 participants
@terrymanu @tristaZero @zangyk