Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#540] Fix parse address error when address has prefix "t" #541

Merged
merged 1 commit into from
Nov 2, 2020
Merged

[#540] Fix parse address error when address has prefix "t" #541

merged 1 commit into from
Nov 2, 2020

Conversation

1216114309zpf
Copy link
Contributor

in same cases, such as addr="http://tim.test.com:9876", then
strings.TrimLeft(addr, "http(s)://") will get "im.test.com:9876" instead
of "tim.test.com:9876"

Signed-off-by: pengfei [email protected]

What is the purpose of the change

bugfix

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

in same cases, such as addr="http://tim.test.com:9876", then
strings.TrimLeft(addr, "http(s)://") will get "im.test.com:9876" instead
of "tim.test.com:9876"

Signed-off-by: pengfei <[email protected]>
@ShannonDing ShannonDing linked an issue Nov 2, 2020 that may be closed by this pull request
@ShannonDing ShannonDing merged commit e1d9be8 into apache:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[master]parse address error when address has prefix "t"
3 participants