Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master]parse address error when address has prefix "t" #540

Closed
1216114309zpf opened this issue Oct 12, 2020 · 0 comments · Fixed by #541
Closed

[master]parse address error when address has prefix "t" #540

1216114309zpf opened this issue Oct 12, 2020 · 0 comments · Fixed by #541

Comments

@1216114309zpf
Copy link
Contributor

The issue tracker is ONLY used for the go client (feature request of RocketMQ need to follow RIP process). Keep in mind, please check whether there is an existing same report before your raise a new one.

Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as to the following:

BUG REPORT
Please add the branch name [Native]/[Master] at the header of the Isssue title.

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      set rocketmq server url as "http://tim.test.com:9876"

    • What did you expect to see?
      parse this url and get address "tim.test.com:9876"

    • What did you see instead?
      get address "im.test.com:9876"

  2. Please tell us about your environment:

    • What is your OS?
      centos

    • What is your client version?
      7

    • What is your RocketMQ version?
      master lastest

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
@ShannonDing ShannonDing linked a pull request Nov 2, 2020 that will close this issue
[#540] Fix parse address error when address has prefix "t" #541
Merged
5 tasks
ShannonDing pushed a commit that referenced this issue Nov 2, 2020
@1216114309zpf
[#540] Fix parse address error when address has prefix "t"
e1d9be8 
in same cases, such as addr="http://tim.test.com:9876", then
strings.TrimLeft(addr, "http(s)://") will get "im.test.com:9876" instead
of "tim.test.com:9876"

Signed-off-by: pengfei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#540] Fix parse address error when address has prefix "t"
1 participant
@1216114309zpf