Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Upgrade OTel library versions #22649

Merged
merged 1 commit into from
May 3, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 3, 2024

Motivation

In Pulsar, a long waited improvement to Otel, metric exporter REUSABLE_DATA memory mode, contributed by @asafm, has been released in 1.37.0 version.
In addition, it's a good practice to stay updated with the experimental API changes within OTel.
For example, in 1.37.0, the opentelemetry-extension-incubator got renamed to opentelemetry-api-incubator and the package name also changed. This impacts the Pulsar client OTel support (PIP-342, #22179).

Modifications

  • upgrades
    • opentelemetry.version: 1.34.1 -> 1.37.0
    • opentelemetry.instrumentation.version: 1.32.1-alpha -> 1.33.2
    • opentelemetry.semconv.version: 1.23.1-alpha -> 1.25.0-alpha
  • start using opentelemetry-instrumentation-bom / opentelemetry-instrumentation-bom-alpha
  • adapt to breaking changes

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone May 3, 2024
@lhotari lhotari requested review from merlimat and asafm May 3, 2024 21:50
@lhotari lhotari self-assigned this May 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 3, 2024
@lhotari lhotari requested a review from heesung-sn May 3, 2024 21:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.73%. Comparing base (bbc6224) to head (f758408).
Report is 222 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22649      +/-   ##
============================================
- Coverage     73.57%   72.73%   -0.85%     
+ Complexity    32624    32554      -70     
============================================
  Files          1877     1887      +10     
  Lines        139502   141014    +1512     
  Branches      15299    15478     +179     
============================================
- Hits         102638   102565      -73     
- Misses        28908    30587    +1679     
+ Partials       7956     7862      -94     
Flag Coverage Δ
inttests 27.20% <ø> (+2.62%) ⬆️
systests 24.68% <ø> (+0.35%) ⬆️
unittests 71.48% <ø> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/client/impl/metrics/Counter.java 100.00% <ø> (ø)
...e/pulsar/client/impl/metrics/LatencyHistogram.java 95.34% <ø> (ø)
...ache/pulsar/client/impl/metrics/UpDownCounter.java 95.00% <ø> (ø)

... and 335 files with indirect coverage changes

@merlimat merlimat merged commit 2821afa into apache:master May 3, 2024
52 of 54 checks passed
@asafm
Copy link
Contributor

asafm commented Jun 1, 2024

Please note 1.38 has everything I designed implemented, including all OTLP exporters. Just need to use the flag for the memory mode as documented in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants