Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] JavaInstanceStarter --tls_allow_insecure default to false #20267

Merged
merged 2 commits into from
Jun 6, 2023
Merged

[fix][fn] JavaInstanceStarter --tls_allow_insecure default to false #20267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ae17c
[feat][fn] JavaInstanceStarter --tls_allow_insecure default to false
michaeljmarshall May 9, 2023
f707cde
Merge remote-tracking branch 'upstream/master' into java-instance-sta…
michaeljmarshall Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ctions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public class JavaInstanceStarter implements AutoCloseable {
public String useTls = Boolean.FALSE.toString();

@Parameter(names = "--tls_allow_insecure", description = "Allow insecure tls connection\n")
public String tlsAllowInsecureConnection = Boolean.TRUE.toString();
public String tlsAllowInsecureConnection = Boolean.FALSE.toString();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhotari - I finally understand why this defaults to arity 1, not 0. It's because the field is a String, not a Boolean or a boolean. Therefore, this change was correct.


@Parameter(names = "--hostname_verification_enabled", description = "Enable hostname verification")
public String tlsHostNameVerificationEnabled = Boolean.FALSE.toString();
Expand Down