[fix][fn] JavaInstanceStarter --tls_allow_insecure default to false #20267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/config
area/function
area/security
doc-not-needed
|
/pulsarbot rerun-failure-checks |
michaeljmarshall
changed the title
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #20267 +/- ##
============================================
- Coverage 72.91% 72.64% -0.27%
+ Complexity 31913 31859 -54
============================================
Files 1867 1867
Lines 138534 139993 +1459
Branches 15200 15507 +307
============================================
+ Hits 101009 101697 +688
- Misses 29517 30211 +694
- Partials 8008 8085 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| public String tlsAllowInsecureConnection = Boolean.TRUE.toString(); | ||
| public String tlsAllowInsecureConnection = Boolean.FALSE.toString(); |
There was a problem hiding this comment.
@lhotari - I finally understand why this defaults to arity 1, not 0. It's because the field is a String, not a Boolean or a boolean. Therefore, this change was correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar's defaults for allowing insecure connections are always
falseexcept for in this one case in theJavaInstanceStarter. A more secure default is to set it tofalse, so I propose we change this default.In this case, we have a default that is likely never used unless someone manually uses the
JavaInstanceStarter. As such, I propose we update this default without requiring a PIP.Modifications
--tls_allow_insecurein theJavaInstanceStarterclassfalse.Verifying this change
I will verify that tests pass.
Does this pull request potentially affect one of the following parts:
Documentation
doc-not-neededThese docs are generated.
Matching PR in forked repository
PR in forked repository: michaeljmarshall#43