Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Remove useless field in the DelayedMessageIndexBucketSegment.proto #20166

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Apr 23, 2023

Motivation & Modifications

image

Remove the useless (not supported)field in the DelayedMessageIndexBucketSegment.proto, It was introduced by PR #20158

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 23, 2023
@coderzc coderzc closed this Apr 23, 2023
@coderzc coderzc reopened this Apr 23, 2023
@coderzc coderzc added area/broker type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages release/3.0.1 labels Apr 23, 2023
@coderzc coderzc added this to the 3.1.0 milestone Apr 23, 2023
@coderzc coderzc changed the title [cleanup][broker] remove useless field in the DelayedMessageIndexBucketSegment.proto [fix][broker] remove useless field in the DelayedMessageIndexBucketSegment.proto Apr 23, 2023
@coderzc coderzc added type/bug The PR fixed a bug or issue reported a bug and removed type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Apr 23, 2023
@coderzc coderzc changed the title [fix][broker] remove useless field in the DelayedMessageIndexBucketSegment.proto [fix][broker] Remove useless field in the DelayedMessageIndexBucketSegment.proto Apr 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20166 (5acb348) into master (6036dcc) will decrease coverage by 0.45%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20166      +/-   ##
============================================
- Coverage     72.93%   72.49%   -0.45%     
+ Complexity    31934     3655   -28279     
============================================
  Files          1868     1868              
  Lines        138449   138458       +9     
  Branches      15235    15235              
============================================
- Hits         100978   100372     -606     
- Misses        29438    30040     +602     
- Partials       8033     8046      +13     
Flag Coverage Δ
inttests 24.34% <0.00%> (+0.23%) ⬆️
systests 24.84% <0.00%> (-0.10%) ⬇️
unittests 71.75% <54.54%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../apache/pulsar/metadata/impl/ZKSessionWatcher.java 97.14% <ø> (ø)
...pulsar/broker/admin/impl/PersistentTopicsBase.java 64.15% <33.33%> (-0.25%) ⬇️
...mon/policies/data/stats/SubscriptionStatsImpl.java 69.91% <50.00%> (-0.74%) ⬇️
...ensions/strategy/LeastResourceUsageWithWeight.java 76.66% <100.00%> (ø)
...ava/org/apache/pulsar/common/naming/TopicName.java 96.33% <100.00%> (ø)

... and 117 files with indirect coverage changes

@coderzc coderzc merged commit ab8a8c9 into apache:master Apr 23, 2023
@coderzc coderzc deleted the fix_bucket_delayed_proto branch April 23, 2023 16:26
poorbarcode pushed a commit that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs release/3.0.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants