-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Optimization protobuf code in the bucket delayed tracker #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
added
area/broker
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
labels
Apr 20, 2023
coderzc
force-pushed
the
improve_bucket_delayed_proto
branch
from
April 20, 2023 15:56
aec64c3
to
4046480
Compare
coderzc
force-pushed
the
improve_bucket_delayed_proto
branch
4 times, most recently
from
April 20, 2023 17:27
34d136b
to
d4633ad
Compare
coderzc
force-pushed
the
improve_bucket_delayed_proto
branch
from
April 20, 2023 17:29
d4633ad
to
52dfa5e
Compare
This reverts commit 463ff66.
mattisonchao
approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #20158 +/- ##
=============================================
+ Coverage 33.17% 72.93% +39.75%
- Complexity 12236 31943 +19707
=============================================
Files 1499 1868 +369
Lines 114413 138431 +24018
Branches 12431 15235 +2804
=============================================
+ Hits 37962 100971 +63009
+ Misses 71499 29432 -42067
- Partials 4952 8028 +3076
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation
Optimization protobuf code in the bucket delayed tracker
Modifications
DelayedMessageIndexBucketSnapshotFormat.proto
toDelayedMessageIndexBucketMetadata.proto
andDelayedMessageIndexBucketSegment.proto
.lightproto-maven-plugin
to generateDelayedMessageIndexBucketSegment.proto
code (Due tolightproto-maven-plugin
don't supportmap
type so keep usingprotobuf-maven-plugin
to generate DelayedMessageIndexBucketMetadata.proto code)popToObject
andpeekTimestamp
method in the DelayedIndexQueue to reduce object createVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: