-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][sql] Bump Trino version to 368 and fix Decimal breaking change #20016
Conversation
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Still some compatibility issue. Convert to draft for now. |
Signed-off-by: tison <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #20016 +/- ##
=============================================
+ Coverage 33.17% 72.85% +39.67%
- Complexity 12158 31628 +19470
=============================================
Files 1499 1861 +362
Lines 113832 137492 +23660
Branches 12368 15145 +2777
=============================================
+ Hits 37769 100170 +62401
+ Misses 71143 29346 -41797
- Partials 4920 7976 +3056
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@merlimat @Technoboy- This patch should be ready to review. The only failed CI is about Spring dep CVE. We actually filter out all pulsar-sql when running OWASP so it should be unrelated. |
Merging... Thanks for your review. |
This is a follow-up to #16683.
And it fixes one of the breaking changes noted at #16494.
The final goal should be catching up to the latest trino version. For compatibility, the Trino community says:
So it seems the breaking changes and incompatibility is how Trino users should be familiar with.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: