Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] Upgrade prestosql to trino #16494

Closed
wants to merge 4 commits into from

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jul 9, 2022

Related to trinodb/trino#8020.

Motivation

Catching up upstream.

Modifications

It seems we meet four major breaking changes:

  1. ConnectorHandleResolver is removed
  2. ConnectorTableLayoutHandle and ConnectorTableLayoutResult are removed.
  3. ColumnMetadata is changed so that we cannot extends it.
  4. Decimal is breaking changed in trinodb/trino@fb88c0b.

cc @kokosing @MarvinCai @lhotari

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • doc-required

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jul 9, 2022
@Anonymitaet
Copy link
Member

FYI: we tried to contribute guides to Trino before

cc @MarvinCai

@tisonkun
Copy link
Member Author

Closed in favor of a PIP to move pulsar-sql to a separated repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants