[fix] [admin] setOffloadThreshold response before it's finished #19370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
approved these changes
Jan 31, 2023
Technoboy-
approved these changes
Jan 31, 2023
|
/pulsarbot rerun-failure-checks |
lhotari
reviewed
Feb 1, 2023
| @@ -2047,7 +2047,7 @@ protected CompletableFuture<Void> internalSetOffloadThresholdInSecondsAsync(long | |||
|
|
|||
| validateNamespacePolicyOperationAsync(namespaceName, PolicyName.OFFLOAD, PolicyOperation.WRITE) | |||
| .thenApply(v -> validatePoliciesReadOnlyAccessAsync()) | |||
There was a problem hiding this comment.
@poorbarcode Thanks for finding the issue and fixing this.
Isn't there a similar bug on the previous line with the validatePoliciesReadOnlyAccessAsync call?
There was a problem hiding this comment.
Ah, you are right. Thanks for helping to check. I have submitted a PR to fix it.
4 tasks
|
This change is to fix the admin API by adding in the below PR which is not included in branch-2.10. So remove the label release 2.10.4. |
|
No need to cherry pick to branch-2.11 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19366
Motivation
Admin API
setOffloadThresholdresponse before it is finished.You can reproduce by
AdminApiOffloadTest.testSetNamespaceOffloadPolicies, If you appendsleep(1000)after this line(pulsar/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Line 468 in 1cd1aef
Modifications
response after it is finishied
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: