-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools #18218
Merged
Technoboy-
merged 16 commits into
apache:master
from
tjiuming:dev/offload_trigger_admin
Nov 21, 2022
Merged
[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools #18218
Technoboy-
merged 16 commits into
apache:master
from
tjiuming:dev/offload_trigger_admin
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjiuming
changed the title
[feat][broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
[broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
Oct 27, 2022
tjiuming
changed the title
[broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
[admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
Oct 27, 2022
tjiuming
changed the title
[admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
[feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
Oct 27, 2022
tjiuming
changed the title
[feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
Oct 27, 2022
codelipenghui
requested review from
mattisonchao,
eolivelli,
codelipenghui,
congbobo184,
gaoran10,
nodece,
RobertIndie and
Technoboy-
October 28, 2022 03:59
Technoboy-
reviewed
Oct 31, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Nov 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java
Outdated
Show resolved
Hide resolved
tjiuming
requested review from
nodece and
Technoboy-
and removed request for
congbobo184,
mattisonchao,
nodece and
Technoboy-
November 2, 2022 17:23
nodece
approved these changes
Nov 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #18218 +/- ##
=============================================
+ Coverage 31.39% 47.26% +15.86%
- Complexity 6651 10465 +3814
=============================================
Files 697 697
Lines 68015 68058 +43
Branches 7285 7286 +1
=============================================
+ Hits 21353 32166 +10813
+ Misses 43667 32311 -11356
- Partials 2995 3581 +586
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Nov 21, 2022
Technoboy-
added
type/feature
The PR added a new feature or issue requested a new feature
area/admin
labels
Nov 21, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/admin
doc-not-needed
Your PR changes do not impact docs
type/feature
The PR added a new feature or issue requested a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add offload managedLedgerOffloadThreshold RestAPI and CLI tools
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: tjiuming#8