Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools #18218

Merged
merged 16 commits into from
Nov 21, 2022

Conversation

tjiuming
Copy link
Contributor

@tjiuming tjiuming commented Oct 27, 2022

Motivation

Add offload managedLedgerOffloadThreshold RestAPI and CLI tools

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tjiuming#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 27, 2022
@tjiuming tjiuming changed the title [feat][broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [broker][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@tjiuming tjiuming changed the title [feat][admin][offload] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools [feat][admin] Add offload managedLedgerOffloadThreshold RestAPI and CLI tools Oct 27, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 28, 2022
@tjiuming tjiuming requested review from nodece and Technoboy- and removed request for congbobo184, mattisonchao, nodece and Technoboy- November 2, 2022 17:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #18218 (77b8032) into master (aeb4503) will increase coverage by 15.86%.
The diff coverage is 76.19%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18218       +/-   ##
=============================================
+ Coverage     31.39%   47.26%   +15.86%     
- Complexity     6651    10465     +3814     
=============================================
  Files           697      697               
  Lines         68015    68058       +43     
  Branches       7285     7286        +1     
=============================================
+ Hits          21353    32166    +10813     
+ Misses        43667    32311    -11356     
- Partials       2995     3581      +586     
Flag Coverage Δ
unittests 47.26% <76.19%> (+15.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 59.74% <71.42%> (+50.40%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 64.13% <80.95%> (+51.94%) ⬆️
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
...apache/pulsar/client/impl/AutoClusterFailover.java 73.33% <0.00%> (-2.78%) ⬇️
...a/org/apache/pulsar/proxy/server/ProxyService.java 80.00% <0.00%> (-0.94%) ⬇️
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 37.11% <0.00%> (-0.06%) ⬇️
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 53.86% <0.00%> (+0.02%) ⬆️
.../pulsar/client/impl/ProducerStatsRecorderImpl.java 84.66% <0.00%> (+0.61%) ⬆️
...va/org/apache/pulsar/client/impl/ProducerImpl.java 17.01% <0.00%> (+1.16%) ⬆️
... and 165 more

@tjiuming
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added type/feature The PR added a new feature or issue requested a new feature area/admin labels Nov 21, 2022
@Technoboy- Technoboy- merged commit 47981c9 into apache:master Nov 21, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin doc-not-needed Your PR changes do not impact docs type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants