-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)" #18751
Merged
codelipenghui
merged 4 commits into
apache:master
from
codelipenghui:penghui/fix-unit-other
Dec 6, 2022
Merged
[fix][test] Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)" #18751
codelipenghui
merged 4 commits into
apache:master
from
codelipenghui:penghui/fix-unit-other
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
ready-to-test
dependencies
Pull requests that update a dependency file
labels
Dec 6, 2022
@codelipenghui Please add the following content to your PR description and select a checkbox:
|
codelipenghui
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Dec 6, 2022
github-actions
bot
added
doc-label-missing
and removed
doc-not-needed
Your PR changes do not impact docs
labels
Dec 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #18751 +/- ##
============================================
+ Coverage 44.79% 47.14% +2.34%
+ Complexity 10026 9331 -695
============================================
Files 703 623 -80
Lines 68808 59072 -9736
Branches 7375 6142 -1233
============================================
- Hits 30822 27849 -2973
+ Misses 34378 28195 -6183
+ Partials 3608 3028 -580
Flags with carried forward coverage won't be shown. Click here to find out more. |
codelipenghui
changed the title
Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)"
[fix][test] Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)"
Dec 6, 2022
codelipenghui
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Dec 6, 2022
github-actions
bot
added
doc-label-missing
doc-not-needed
Your PR changes do not impact docs
and removed
doc-not-needed
Your PR changes do not impact docs
doc-label-missing
labels
Dec 6, 2022
Technoboy-
approved these changes
Dec 6, 2022
coderzc
approved these changes
Dec 6, 2022
tisonkun
approved these changes
Dec 6, 2022
labuladong
approved these changes
Dec 6, 2022
13 tasks
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
doc-not-needed
Your PR changes do not impact docs
ready-to-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18732
Motivation
Revert #18467 to fix the JVM crash issue, which has been described in #18732
After the CI gets passed. I will create a GitHub issue for the caffeine repo
Documentation
doc
doc-required
doc-not-needed
doc-complete