Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][misc] Update caffeine from 2.9.1 to 3.1.2 #18647

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

hezhangjian
Copy link
Member

@hezhangjian hezhangjian commented Nov 28, 2022

Motivation

Now we only use caffeine in broker module. caffeine has a jdk11+ version, which is more proper for jdk11+ project to integrated with.(Spring3.0 uses caffeine 3.X too.) So I think it's worth for us to update caffeine to 3.x

Modifications

Update caffeine from 2.9.1 to 3.1.2

  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

#18647

@github-actions
Copy link

@Shoothzj Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codelipenghui codelipenghui added this to the 2.12.0 milestone Nov 28, 2022
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs dependencies Pull requests that update a dependency file and removed doc-label-missing labels Nov 28, 2022
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Nov 28, 2022
@hezhangjian hezhangjian changed the title Update caffeine from 2.9.1 to 3.1.2 [ imporve] [dependency] Update caffeine from 2.9.1 to 3.1.2 Nov 28, 2022
@hezhangjian hezhangjian changed the title [ imporve] [dependency] Update caffeine from 2.9.1 to 3.1.2 [imporve] [dependency] Update caffeine from 2.9.1 to 3.1.2 Nov 28, 2022
@hezhangjian hezhangjian changed the title [imporve] [dependency] Update caffeine from 2.9.1 to 3.1.2 [improve] [dependency] Update caffeine from 2.9.1 to 3.1.2 Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #18647 (55263b6) into master (b579bb8) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18647      +/-   ##
============================================
- Coverage     47.51%   47.30%   -0.22%     
+ Complexity    10520    10461      -59     
============================================
  Files           698      698              
  Lines         68079    68079              
  Branches       7280     7280              
============================================
- Hits          32351    32203     -148     
- Misses        32151    32303     +152     
+ Partials       3577     3573       -4     
Flag Coverage Δ
unittests 47.30% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) ⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java 38.56% <0.00%> (-9.16%) ⬇️
...ction/buffer/impl/TransactionBufferClientImpl.java 76.74% <0.00%> (-4.66%) ⬇️
.../buffer/impl/TransactionBufferClientStatsImpl.java 82.00% <0.00%> (-4.00%) ⬇️
...pulsar/broker/TransactionMetadataStoreService.java 58.51% <0.00%> (-3.94%) ⬇️
...ookkeeper/mledger/impl/ManagedCursorContainer.java 76.03% <0.00%> (-3.31%) ⬇️
...roker/service/persistent/MessageDeduplication.java 50.65% <0.00%> (-3.06%) ⬇️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 71.68% <0.00%> (-2.57%) ⬇️
...tion/buffer/impl/TransactionBufferHandlerImpl.java 50.00% <0.00%> (-2.54%) ⬇️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 57.65% <0.00%> (-1.99%) ⬇️
... and 29 more

@Technoboy- Technoboy- changed the title [improve] [dependency] Update caffeine from 2.9.1 to 3.1.2 [improve][dependency] Update caffeine from 2.9.1 to 3.1.2 Nov 28, 2022
@hezhangjian hezhangjian changed the title [improve][dependency] Update caffeine from 2.9.1 to 3.1.2 [improve][misc] Update caffeine from 2.9.1 to 3.1.2 Nov 28, 2022
@hezhangjian hezhangjian merged commit 8d3df45 into apache:master Nov 28, 2022
@hezhangjian hezhangjian deleted the caffeine-3-x branch November 28, 2022 07:05
codelipenghui added a commit to codelipenghui/incubator-pulsar that referenced this pull request Dec 6, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
### Motivation

Now we only use caffeine in broker module. *caffeine* has a jdk11+ version, which is more proper for jdk11+ project to integrated with.(Spring3.0 uses caffeine 3.X too.) So I think it's worth for us to update caffeine to 3.x

### Modifications

Update caffeine from 2.9.1 to 3.1.2

- [ ] Anything that affects deployment

### Documentation

<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->

- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

### Matching PR in forked repository

apache#18647
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
### Motivation

Now we only use caffeine in broker module. *caffeine* has a jdk11+ version, which is more proper for jdk11+ project to integrated with.(Spring3.0 uses caffeine 3.X too.) So I think it's worth for us to update caffeine to 3.x

### Modifications

Update caffeine from 2.9.1 to 3.1.2

- [ ] Anything that affects deployment

### Documentation

<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->

- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

### Matching PR in forked repository

apache#18647
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
lhotari pushed a commit to apache/pulsar-sql that referenced this pull request Oct 18, 2024
### Motivation

Now we only use caffeine in broker module. *caffeine* has a jdk11+ version, which is more proper for jdk11+ project to integrated with.(Spring3.0 uses caffeine 3.X too.) So I think it's worth for us to update caffeine to 3.x

### Modifications

Update caffeine from 2.9.1 to 3.1.2

- [ ] Anything that affects deployment

### Documentation

<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->

- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

### Matching PR in forked repository

apache/pulsar#18647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants