Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][doc] Fix all 404 link for example openssl.cnf #18667

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[fix][doc] Fix all 404 link for example openssl.cnf #18667

merged 1 commit into from
Nov 29, 2022

Conversation

RobertIndie
Copy link
Member

Fixes #18656

Motivation

There are many url like wget https://raw.githubusercontent.com/apache/pulsar-site/main/site2/website/static/examples/openssl.cnf link to the openssl.cnf. But this file was deleted at apache/pulsar-site#215.

Modifications

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@RobertIndie RobertIndie added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 29, 2022
@RobertIndie RobertIndie added this to the 2.12.0 milestone Nov 29, 2022
@RobertIndie RobertIndie self-assigned this Nov 29, 2022
This was referenced Nov 29, 2022
Closed
Merged
momo-jun
momo-jun approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

tisonkun
tisonkun approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging...

@tisonkun tisonkun merged commit 0fd1a53 into apache:master Nov 29, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
@RobertIndie @lifepuzzlefun
[fix][doc] Fix all 404 link for example openssl.cnf (apache#18667)
43ea63f 
Signed-off-by: Zike Yang <[email protected]>
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@RobertIndie @lifepuzzlefun
[fix][doc] Fix all 404 link for example openssl.cnf (apache#18667)
1f38e48 
Signed-off-by: Zike Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-jun momo-jun momo-jun approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

@RobertIndie RobertIndie

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[Doc] 404 URL for openssl.cnf example
3 participants
@RobertIndie @tisonkun @momo-jun