[improve][doc] Add documents for C++ client 3.0.0 or later #18574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
the
doc
|
Previews:
|
BewareMyPower
changed the title
tisonkun
reviewed
Nov 23, 2022
site2/docs/client-libraries-cpp.md
Outdated
| ### APK | ||
|
|
||
| ```bash | ||
| apk add --allow-untrusted ./apache-pulsar-client-3.0.0-r0.apk |
There was a problem hiding this comment.
Do we stick to 3.0.0 in the document here? If so, you may update the links above for other hard linked items (RPM, DEB).
There was a problem hiding this comment.
I think we can use apache-pulsar-client-*.apk instead.
site2/docs/client-libraries-cpp.md
Outdated
| ### APK | ||
|
|
||
| ```bash | ||
| apk add --allow-untrusted ./apache-pulsar-client-3.0.0-r0.apk |
There was a problem hiding this comment.
Also, it seems to me that -r0 referred to a release candidate, is it a formal release?
There was a problem hiding this comment.
shibd
reviewed
Nov 23, 2022
|
|
||
| The version of the Pulsar C++ client is no longer consistent with Pulsar after 2.10.x. The new client version starts from 3.0.0. You can turn to [the download page](https://pulsar.apache.org/download) to see the latest releases. | ||
|
|
||
| Take the [3.0.0 release](https://archive.apache.org/dist/pulsar/pulsar-client-cpp-3.0.0/) for example, there are following subdirectories: |
There was a problem hiding this comment.
After 3.0, do we no longer support brew install?
There was a problem hiding this comment.
We still support brew install, see Homebrew/homebrew-core#114737
momo-jun
reviewed
Nov 23, 2022
momo-jun
reviewed
Nov 23, 2022
Co-authored-by: tison <[email protected]>
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: tison <[email protected]>
tisonkun
approved these changes
Nov 23, 2022
RobertIndie
approved these changes
Nov 24, 2022
|
Merging... |
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
) Co-authored-by: tison <[email protected]> Co-authored-by: momo-jun <[email protected]>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
) Co-authored-by: tison <[email protected]> Co-authored-by: momo-jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's a followup PR of apache/pulsar-site#300, which shows the download URLs of the separated C++ client repo. This PR adds the guidance to tell users where to download the new released C++ client (3.0.0 or later).
Modifications
Reference the download page for the C++ client 3.0.0 or higher and explain the packages simply. Add a section to describe how to install the APK (Alpine Package Keeper) package.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: This is a pure doc related PR, no matching PR is needed.