Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpulsar 3.0.0 #114737

Closed

Conversation

michaeljmarshall
Copy link
Contributor

@michaeljmarshall michaeljmarshall commented Nov 4, 2022

The Apache Pulsar project recently moved libpulsar to its own repository. Here is the relevant mailing list thread:
https://lists.apache.org/thread/h3gkrp5fc8q3n80bnf8lt9wrt7zg0xrv

The new libpulsar repository has an independent release cycle and is located here https://github.com/apache/pulsar-client-cpp.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added boost Boost use is a significant feature of the PR or issue automerge-skip `brew pr-automerge` will skip this pull request labels Nov 4, 2022
@chenrui333
Copy link
Member

chenrui333 commented Nov 4, 2022

Instead of doing merge commit (it would trigger automerge-skip), can you rebase to the latest master?

Formula/libpulsar.rb Outdated Show resolved Hide resolved
Formula/libpulsar.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 5, 2022
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 6, 2022
@chenrui333
Copy link
Member

failed on linux build

  make[3]: Entering directory '/tmp/libpulsar-20221106-11011-1y4pqq/apache-pulsar-client-cpp-3.0.0'
  make[3]: *** No rule to make target '/home/linuxbrew/.linuxbrew/opt/protobuf/lib/libprotobuf.dylib', needed by 'lib/libpulsar.so'.  Stop.
  make[3]: Leaving directory '/tmp/libpulsar-20221106-11011-1y4pqq/apache-pulsar-client-cpp-3.0.0'
  make[2]: *** [CMakeFiles/Makefile2:221: lib/CMakeFiles/pulsarShared.dir/all] Error 2
  make[2]: Leaving directory '/tmp/libpulsar-20221106-11011-1y4pqq/apache-pulsar-client-cpp-3.0.0'
  make[1]: *** [CMakeFiles/Makefile2:228: lib/CMakeFiles/pulsarShared.dir/rule] Error 2
  make[1]: Leaving directory '/tmp/libpulsar-20221106-11011-1y4pqq/apache-pulsar-client-cpp-3.0.0'
  make: *** [Makefile:211: pulsarShared] Error 2

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Nov 6, 2022
Formula/libpulsar.rb Outdated Show resolved Hide resolved
@michaeljmarshall
Copy link
Contributor Author

@chenrui333 - thanks for the pointer. I updated the PR and the tests are now passing.

Formula/libpulsar.rb Outdated Show resolved Hide resolved
Formula/libpulsar.rb Outdated Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pulsar.apache.org/download

Latest stable seems to still be 2.10.2. Or are versions for this announced elsewhere?

@merlimat
Copy link
Contributor

@carlocab We have changed the release versioning for C++ client which has been moved to new repository out of the main Pulsar repo: https://github.com/apache/pulsar-client-cpp

Release https://github.com/apache/pulsar-client-cpp/releases/tag/v3.0.0

@michaeljmarshall
Copy link
Contributor Author

@carlocab - that is also why I contributed #114724. Note that the link in my PR description is to the official Apache Pulsar mailing list decision to break out the project.

@merlimat
Copy link
Contributor

@BewareMyPower
Copy link
Contributor

BewareMyPower commented Nov 23, 2022

ping @carlocab

Could you take a look again? The release can be seen here

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 15, 2022
carlocab
carlocab previously approved these changes Dec 15, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, too many notifications!

@carlocab carlocab removed the stale No recent activity label Dec 15, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review December 15, 2022 04:04

bottle publish failed

@michaeljmarshall
Copy link
Contributor Author

3.1.0 was already released and the homebrew update was merged here #118135. Closing this as it is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. linux Linux is specifically affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants