[fix][test] flaky test ManagedLedgerBkTest.asyncMarkDeleteAndClose

[poorbarcode]

Fixes #16729

Motivation

same as #18310

ManagedCursorImpl has a known problem: when the cursor.close and the cursor.switchLedger are concurrent executing, a bad version exception is thrown. see:

pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java

Lines 2595 to 2619 in 0c3c175

	if (e instanceof MetaStoreException.BadVersionException) {
	log.warn("[{}] Failed to update cursor metadata for {} due to version conflict {}",
	ledger.name, name, e.getMessage());
	// it means previous owner of the ml might have updated the version incorrectly. So, check
	// the ownership and refresh the version again.
	if (ledger.mlOwnershipChecker != null && ledger.mlOwnershipChecker.get()) {
	ledger.getStore().asyncGetCursorInfo(ledger.getName(), name,
	new MetaStoreCallback<ManagedCursorInfo>() {
	@Override
	public void operationComplete(ManagedCursorInfo info, Stat stat) {
	updateCursorLedgerStat(info, stat);
	}
	@Override
	public void operationFailed(MetaStoreException e) {
	if (log.isDebugEnabled()) {
	log.debug(
	"[{}] Failed to refresh cursor metadata-version for {} due "
	+ "to {}", ledger.name, name, e.getMessage());
	}
	}
	});
	}
	}
	callback.operationFailed(e);

Modifications

• managedLedger.close triggers the cursor.close, so remove code cursor.close
• if managedLedger.close fail, just retry, it will be ok

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

• [ci][fix][test]fix flaky test ManagedLedgerBkTest.asyncMarkDeleteAndClose poorbarcode/pulsar#38

[codecov-commenter]

Codecov Report

Merging #18362 (fd24928) into master (8b404d4) will decrease coverage by 0.02%.
The diff coverage is 6.12%.

@@             Coverage Diff              @@
##             master   #18362      +/-   ##
============================================
- Coverage     47.15%   47.12%   -0.03%     
+ Complexity    10432    10411      -21     
============================================
  Files           697      698       +1     
  Lines         68023    67986      -37     
  Branches       7284     7271      -13     
============================================
- Hits          32074    32041      -33     
- Misses        32367    32400      +33     
+ Partials       3582     3545      -37     

Flag	Coverage Δ
unittests	47.12% <6.12%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java	22.98% <0.00%> (+0.71%)	⬆️
...n/java/org/apache/pulsar/client/util/NoOpLock.java	0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java	15.12% <7.69%> (+0.28%)	⬆️
...va/org/apache/pulsar/client/impl/ConsumerBase.java	21.93% <16.66%> (-0.02%)	⬇️
...apache/pulsar/broker/service/TopicListService.java	10.65% <0.00%> (-44.27%)	⬇️
...java/org/apache/pulsar/proxy/stats/TopicStats.java	58.82% <0.00%> (-41.18%)	⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java	46.03% <0.00%> (-14.86%)	⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java	40.74% <0.00%> (-12.35%)	⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java	70.76% <0.00%> (-7.70%)	⬇️
.../pulsar/broker/service/PublishRateLimiterImpl.java	58.00% <0.00%> (-6.00%)	⬇️
... and 53 more

[poorbarcode]

/pulsarbot rerun-failure-checks

[tisonkun]

Although I suspect we may not retry on failure, the change is OK to merge.