[improve][broker] Get lowest PositionImpl from NavigableSet #18278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change signature from Set<T> to NavigableSet<T> which makes the caller to get lowest PositionImpl more efficient.
lifepuzzlefun
changed the title
|
@codelipenghui @Jason918 please take a look, thank you~ |
| @@ -285,7 +286,7 @@ public synchronized void readMoreEntries() { | |||
| } | |||
|
|
|||
| havePendingReplayRead = true; | |||
| minReplayedPosition = messagesToReplayNow.stream().min(PositionImpl::compareTo).orElse(null); | |||
| minReplayedPosition = messagesToReplayNow.pollFirst(); | |||
There was a problem hiding this comment.
It should be first(), not pollFirst()?
There was a problem hiding this comment.
fixed, thanks for review.
codelipenghui
approved these changes
Nov 1, 2022
codelipenghui
added
ready-to-test
type/enhancement
codelipenghui
changed the title
codelipenghui
requested review from
congbobo184,
gaoran10,
mattisonchao,
Technoboy-,
nodece and
RobertIndie
|
/pulsarbot run-failure-checks |
nodece
reviewed
Nov 1, 2022
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Show resolved
Hide resolved
coderzc
approved these changes
Nov 1, 2022
nodece
approved these changes
Nov 2, 2022
|
/pulsarbot run-failure-checks |
labuladong
approved these changes
Nov 2, 2022
…osition' into direct_use_tree_map_to_get_lowest_position
Codecov Report
@@ Coverage Diff @@
## master #18278 +/- ##
============================================
+ Coverage 38.97% 39.92% +0.94%
- Complexity 8311 8591 +280
============================================
Files 683 687 +4
Lines 67325 67381 +56
Branches 7217 7217
============================================
+ Hits 26239 26899 +660
+ Misses 38079 37502 -577
+ Partials 3007 2980 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/pulsarbot run-failure-checks |
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
May 9, 2023
…8278) * [cleanup] Direct get lowest PositionImpl from TreeMap change signature from Set<T> to NavigableSet<T> which makes the caller to get lowest PositionImpl more efficient. * change poll to first when call `NavigableSet` * fix check style remove unused import Co-authored-by: wangjinlong <[email protected]>
Technoboy-
pushed a commit
that referenced
this pull request
May 23, 2023
* [cleanup] Direct get lowest PositionImpl from TreeMap change signature from Set<T> to NavigableSet<T> which makes the caller to get lowest PositionImpl more efficient. * change poll to first when call `NavigableSet` * fix check style remove unused import Co-authored-by: wangjinlong <[email protected]>
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 6, 2023
…8278) * [cleanup] Direct get lowest PositionImpl from TreeMap change signature from Set<T> to NavigableSet<T> which makes the caller to get lowest PositionImpl more efficient. * change poll to first when call `NavigableSet` * fix check style remove unused import Co-authored-by: wangjinlong <[email protected]> (cherry picked from commit 01badd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18279
Motivation
change signature from
Set<T>toNavigableSet<T>which makes the caller to get lowest
PositionImplmore efficient ( compare withstream().findfirst())Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Documentation
docdoc-requireddoc-not-neededdoc-complete