Fix creating producer or consumer is not retried for connection failure #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/retry-create-handler
branch
from
56c4864 to
c4d1473
Compare
4 tasks
BewareMyPower
force-pushed
the
bewaremypower/retry-create-handler
branch
from
c59a2f3 to
9b57972
Compare
BewareMyPower
force-pushed
the
bewaremypower/retry-create-handler
branch
from
9b57972 to
60f262b
Compare
BewareMyPower
force-pushed
the
bewaremypower/retry-create-handler
branch
from
544f43c to
8528a23
Compare
Fixes apache#391 ### Motivation When `connectionFailed` is called, no matter if the result is retryable the creation of producer or consumer will fail without retry. ### Modifications Check if the result is retryable in `connectionFailed` for `ProducerImpl` and `ConsumerImpl` and only fail for non-retryable errors or the timeout error. Register another timer in `HandlerBase` to propagate the timeout error to `connectionFailed`. Add `testRetryUntilSucceed`, `testRetryTimeout`, `testNoRetry` to verify client could retry according to the result returned by `ClientImpl::getConnection`.
BewareMyPower
force-pushed
the
bewaremypower/retry-create-handler
branch
from
1b7a596 to
198b998
Compare
merlimat
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
Motivation
When
connectionFailedis called, no matter if the result is retryable the creation of producer or consumer will fail without retry.Modifications
Check if the result is retryable in
connectionFailedforProducerImplandConsumerImpland only fail for non-retryable errors or the timeout error. Register another timer inHandlerBaseto propagate the timeout error toconnectionFailed.Add
testRetryUntilSucceed,testRetryTimeout,testNoRetryto verify client could retry according to the result returned byClientImpl::getConnection.