Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StartMessageIdInclusive not work when reader reads from latest msg id #386

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

RobertIndie
Copy link
Member

Fixes #385

Motivation

The reader with StartMessageIdInclusive enabled should be able to reads messages from the latest message ID.

Modifications

  • If StartMessageIdInclusive is enabled, the reader will seek and read the latest message in the topic.

Verifying this change

This change added tests.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    It's a bug fix

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie added the bug Something isn't working label Jan 12, 2024
@RobertIndie RobertIndie added this to the 3.5.0 milestone Jan 12, 2024
@RobertIndie RobertIndie self-assigned this Jan 12, 2024
@RobertIndie RobertIndie changed the title Fix inclusive StartMessageIdInclusive not work when reader reads from latest msg id Fix StartMessageIdInclusive not work when reader reads from latest msg id Jan 12, 2024
lib/ConsumerImpl.cc Outdated Show resolved Hide resolved
@RobertIndie RobertIndie merged commit a1cf401 into apache:main Jan 15, 2024
12 checks passed
@Samreay
Copy link

Samreay commented Feb 4, 2024

Is there any chance we can get a client with this bugfix released?

@BewareMyPower
Copy link
Contributor

You might need to wait for 3.5.0 release maybe at the end of this month.

@Samreay
Copy link

Samreay commented Feb 5, 2024

Is main broken at the moment with an incomplete feature or similar? Not trying to be pushy here, just unsure what process is in the way of releasing bugfixes once they're completed instead of waiting on something unspecified

@BewareMyPower
Copy link
Contributor

No. But there is an important fix I'm working on: #396

And yes, it's okay to drive a 3.5.0 release recently once it's done. I just realized there are about 2 months since the last 3.4.2 release.

@BewareMyPower
Copy link
Contributor

Generally, the vote process takes about a week to complete. Specifically, Chinese New Year is coming so I might not have enough time to drive this release next week.

@Samreay
Copy link

Samreay commented Feb 5, 2024

Ah, I didn't realise you had such a length voting system. Sounds like... fun? Good luck with the fixes then, and enjoy Chinese New Year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Inclusive start message Id not work when reader reads from latest msg id
3 participants