Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go version currency - add 1.15 and deprecate 1.11 #4987

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Go version currency - add 1.15 and deprecate 1.11 #4987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ansible/files/runtimes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,20 @@
"go": [
{
"kind": "go:1.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we even keep this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should definitely remove go:1.11 before a 1.0.0 release.

I was thinking we would do the remove in a separate PR in case downstreams wanted more control.

"default": false,
"deprecated": true,
"attached": {
"attachmentName": "codefile",
"attachmentType": "text/plain"
},
"image": {
"prefix": "openwhisk",
"name": "action-golang-v1.11",
"tag": "nightly"
}
},
{
"kind": "go:1.15",
"default": true,
"deprecated": false,
"attached": {
Expand All @@ -204,7 +218,7 @@
},
"image": {
"prefix": "openwhisk",
"name": "action-golang-v1.11",
"name": "action-golang-v1.15",
"tag": "nightly"
}
}
Expand Down