Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go version currency - add 1.15 and deprecate 1.11 #4987

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

dgrove-oss
Copy link
Member

Mark action kind go:1.11 as deprecated
Add action kind go:1.15 and make it default for Go actions.

Mark action kind go:1.11 as deprecated
Add action kind go:1.15 and make it default for Go actions.
@@ -196,6 +196,20 @@
"go": [
{
"kind": "go:1.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we even keep this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should definitely remove go:1.11 before a 1.0.0 release.

I was thinking we would do the remove in a separate PR in case downstreams wanted more control.

@dgrove-oss dgrove-oss merged commit b00678d into apache:master Sep 30, 2020
@dgrove-oss dgrove-oss deleted the golang-versions branch September 30, 2020 12:18
dgrove-oss added a commit to dgrove-oss/openwhisk that referenced this pull request Oct 13, 2020
Missing part of apache#4987 which added the go:1.15 kind.
dgrove-oss added a commit that referenced this pull request Oct 13, 2020
Missing part of #4987 which added the go:1.15 kind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants