MINIFICPP-1616 Create PutAzureDatalakeStorage processor #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-1616
branch
2 times, most recently
from
2a42a33
to
68d1283
Compare
lordgamez
force-pushed
the
MINIFICPP-1616
branch
2 times, most recently
from
86eee01
to
680c70c
Compare
lordgamez
force-pushed
the
MINIFICPP-1616
branch
2 times, most recently
from
c62cef1
to
41275a4
Compare
fgerlits
reviewed
Sep 15, 2021
fgerlits
approved these changes
Sep 15, 2021
arpadboda
reviewed
Sep 16, 2021
| @@ -90,14 +81,13 @@ const core::Relationship PutAzureBlobStorage::Failure("failure", "Unsuccessful o | |||
|
|
|||
| void PutAzureBlobStorage::initialize() { | |||
| // Set the supported properties | |||
| setSupportedProperties({ | |||
| updateSupportedProperties({ | |||
There was a problem hiding this comment.
Why not set?
Update would make sense to me in case the base class would already set some properties, but that doesn't seem to happen as far as I see.
There was a problem hiding this comment.
The base class AzureStorageProcessorBase does set the AzureStorageCredentialsService property beforehand in its constructor.
There was a problem hiding this comment.
Updated in f02f86c
szaszm
reviewed
Sep 16, 2021
lordgamez
force-pushed
the
MINIFICPP-1616
branch
from
c8257e4
to
f02f86c
Compare
szaszm
reviewed
Sep 21, 2021
szaszm
approved these changes
Sep 21, 2021
adamdebreceni
approved these changes
Sep 22, 2021
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Azure Data Lake Storage is not supported by the Azurite docker image, so the system testing was only done manually.
https://issues.apache.org/jira/browse/MINIFICPP-1616
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.