MINIFICPP-1691: PutSplunkHTTP and QuerySplunkIndexingStatus #1219
Conversation
| name=self.name, | ||
| network=self.network.name, | ||
| environment=[ | ||
| "SPLUNK_START_ARGS=--accept-license", |
There was a problem hiding this comment.
What license are we accepting here without a prompt? I found an Apache License 2.0 on their page, but it seems strange that they would require accepting an open source license in such a verbose way.
There was a problem hiding this comment.
They have different license terms based on the type we are using.
https://docs.splunk.com/Documentation/Splunk/8.2.4/Admin/TypesofSplunklicenses
The whole eula can be found here: https://www.splunk.com/eula/sii/1.4
I changed this section in b79afde so we explicity accept the free license which can be used to for these kinds of tests(we only use this container for the integration tests) more about it here: https://docs.splunk.com/Documentation/Splunk/8.2.4/Admin/TypesofSplunklicenses#Free_license
There was a problem hiding this comment.
This is non-free software, but I think it's fine as long as we are not shipping any of it.
Co-authored-by: Márton Szász <[email protected]>
Co-authored-by: Márton Szász <[email protected]>
MiNiFi C++ implementation of the processors added to NiFi in https://issues.apache.org/jira/browse/NIFI-7801
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.