Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[PLEASE DO NOT REVIEW] Trying to fix issue #17840 #18521

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jinboci
Copy link
Contributor

@jinboci jinboci commented Jun 9, 2020

Description

(Brief description on what this PR is about)
Trying to fix #17840. Command import mxnet as mx causes error messages. Comment 3rdparty/tvm/src/runtime/module.cc:60-61 to block this error.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @jinboci , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-gpu, edge, sanity, clang, unix-gpu, miscellaneous, windows-cpu, windows-gpu, website, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

tvm::runtime::TVMOpModule::Get()->Load(libpath);
tvm::runtime::TVMOpModule *libpath_module = tvm::runtime::TVMOpModule::Get();
libpath_module->Load(libpath);
tvm::runtime::TVMOpModule *cubin_module = tvm::runtime::TVMOpModule::Get();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvm::runtime::TVMOpModule::Get() returns a singleton, thus libpath_module and cubin_module are essentially the same object.

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 26, 2020
Syncing with Apache/master
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review labels Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TVMOp doesn't work well with GPU builds
5 participants