Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

TVMOp doesn't work well with GPU builds #17840

Open
apeforest opened this issue Mar 15, 2020 · 7 comments · May be fixed by #18521
Open

TVMOp doesn't work well with GPU builds #17840

apeforest opened this issue Mar 15, 2020 · 7 comments · May be fixed by #18521
Assignees
Labels
Bug Numpy TVM OP Operators implemented using TVM v2.0 WIP

Comments

@apeforest
Copy link
Contributor

Description

A few recent PRs failed at the same place related to TVM op.

#17835
#17795
#17531

@yzhliu

@leezu
Copy link
Contributor

leezu commented Mar 18, 2020

@apeforest do you mean this error:

[2020-03-18T08:37:14.025Z] TVMError: Check failed: ret == 0 (-1 vs. 0) : Check failed: f != nullptr: Cannot find function less_scalar_gpufloat32_2bool_2_kernel0 in the imported modules or global registry

@apeforest
Copy link
Contributor Author

Yes, but it seems to be fixed.

@leezu
Copy link
Contributor

leezu commented Mar 18, 2020

Why would it be fixed? I got this error 2020-03-18T08:37:14.025Z UTC

@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Apr 28, 2020

The issue persists. Upon trying unix-gpu build on G4 in CI Dev account.
http://jenkins.mxnet-ci-dev.amazon-ml.com/blue/organizations/jenkins/mxnet-validation-bapac%2Funix-gpu/detail/update_gpu_toolchain/8/pipeline/414

all 3 failed tests fail in a similar fashion
they fail at 7 tests with the following error

TVMError: Check failed: ret == 0 (-1 vs. 0) : Check failed: f != nullptr: Cannot find function  <x> in the imported modules or global registry

Internal functions that can't be found

greater_equal_gpufloat32_0float32_0bool_0_kernel0 (x2)
logical_and_gpufloat32_1float32_1bool_1_kernel0 (x2)
equal_gpufloat32_2float32_2bool_2_kernel0 (x2)
sum_gpureduce1st_dim_1req_kWriteTobool_5float32_2float32_2_kernel0 (x3)
cuda_rad2degfloat32_2float32_2_kernel0 (x2)

7 Tests that fail as a result

tests/python/unittest/test_numpy_interoperability.py:test_np_array_function_protocol
tests/python/unittest/test_numpy_interoperability.py:test_np_array_ufunc_protocol

tests/python/unittest/test_numpy_ndarray.py:test_np_ndarray_binary_element_wise_ops

tests/python/unittest/test_numpy_op.py:test_np_sum
tests/python/unittest/test_numpy_op.py:test_np_mean
tests/python/unittest/test_numpy_op.py:test_np_unary_funcs
tests/python/unittest/test_numpy_op.py:test_np_binary_funcs

@leezu
Copy link
Contributor

leezu commented Apr 29, 2020

Reproducer
Compile MXNet with USE_TVMOP=1.

import mxnet as mx

x = mx.np.array([[0, 1], [1, 1], [2, 2]], ctx=mx.gpu())
idx = x < 2
x[idx]

leezu added a commit that referenced this issue May 1, 2020
@leezu leezu changed the title CI unix-gpu build failure in TVM op TVMOp doesn't work well with GPU builds May 1, 2020
@leezu
Copy link
Contributor

leezu commented May 1, 2020

Has been disabled on CI: #18204

Let's track fixing TVMOp in this issue?

@yzhliu
Copy link
Member

yzhliu commented May 9, 2020

@jinboci will be helping

@jinboci jinboci linked a pull request Jun 9, 2020 that will close this issue
7 tasks
jinboci pushed a commit to jinboci/incubator-mxnet that referenced this issue Jun 9, 2020
jinboci pushed a commit to jinboci/incubator-mxnet that referenced this issue Jun 9, 2020
jinboci pushed a commit to jinboci/incubator-mxnet that referenced this issue Jun 9, 2020
This was referenced Jun 9, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this issue Jul 6, 2020
yzhliu pushed a commit that referenced this issue Aug 22, 2020
* fix the error message of reshape()

* Fixing issue #16655 reshape() error message

* test pr

* fixing #17840

* fixing issue #17840

* Update compile.py

* Update ndarray.py

* Update c_api.cc

* Update op_module.cc

* Update op_module.h

* Update op_module.h

* Update op_module.h

* fixing tvmgpu issue & not restoring tvmop checks

Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: jinboci <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Numpy TVM OP Operators implemented using TVM v2.0 WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants