-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-908] Enable minimal OSX Travis build (v1.3.x) #13179
Conversation
This turns on python tests in Travis in order to increase or MacOS coverage.
Fixes: apache#12089 MacOS python tests are failing. This seems to be because OpenCV on brew is missing some threading symbols that we're calling. As a work around I'm reverting to a previously working behaviour (not setting threading limits explicitly on MacOS builds).
There are a few more Travis related PRs. Please add these commits as well as they ensure high stability of Travis. |
on_failure: always | ||
#slack: dmlc:NmroCzntCiWOuxUZpii40USd | ||
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0 | ||
- mv make/osx.mk config.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to modify code for now, just porting things.
@mxnet-label-bot [pr-awaiting-review] |
I'm not in favour of enabling tests due to the timeout |
I agree with @marcoabreu lets not add it to the branch |
@marcoabreu @nswamy I think the timeout is not happening on the branch. Let's merge and observe, this will not harm, but in case it will work has the benefit to cover MacOS with testing. |
@marcoabreu @nswamy You were right about the timeout, disabled the tests, but kept the build. |
@@ -60,7 +60,7 @@ class LibraryInitializer { | |||
// Make children single threaded since they are typically workers | |||
dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1); | |||
dmlc::SetEnv("OMP_NUM_THREADS", 1); | |||
#if MXNET_USE_OPENCV | |||
#if MXNET_USE_OPENCV && !__APPLE__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for not disabling opencv threads on mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KellenSunderland do you know why this is done? As said previously, my task here was to port commits from master to the release branch and make only necessary changes.
@lebeg I am not seeing a need for the OS X builds since the tests are disabled and also this did not exist for 1.3.0 |
@nswamy Ok, for clarity I understand this as: Strongly opposed to have it in the release branch. I'm not seeing that much risk as you do, but I commit to this decision and close this PR. |
Description
Port of #12462 to the v1.3.x release branch.
Includes following PR's as well:
[MXNET-908] Enable python tests in Travis
#12550
[MXNET-968] Fix MacOS python tests
#12590
And due to timeout:
Disable travis tests
#13137
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments