Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-908] Enable minimal OSX Travis build (v1.3.x) #13179

Closed
wants to merge 4 commits into from

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Nov 8, 2018

Description

Port of #12462 to the v1.3.x release branch.

Includes following PR's as well:

[MXNET-908] Enable python tests in Travis
#12550

[MXNET-968] Fix MacOS python tests
#12590

And due to timeout:

Disable travis tests
#13137

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lebeg lebeg requested a review from marcoabreu as a code owner November 8, 2018 08:55
@lebeg
Copy link
Contributor Author

lebeg commented Nov 8, 2018

KellenSunderland and others added 2 commits November 8, 2018 09:59
This turns on python tests in Travis in order to increase or MacOS coverage.
Fixes: apache#12089
MacOS python tests are failing.  This seems to be because OpenCV on
brew is missing some threading symbols that we're calling.  As a work
around I'm reverting to a previously working behaviour (not setting
threading limits explicitly on MacOS builds).
@marcoabreu
Copy link
Contributor

There are a few more Travis related PRs. Please add these commits as well as they ensure high stability of Travis.

on_failure: always
#slack: dmlc:NmroCzntCiWOuxUZpii40USd
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0
- mv make/osx.mk config.mk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to modify code for now, just porting things.

@anirudhacharya
Copy link
Member

@mxnet-label-bot [pr-awaiting-review]

@marcoabreu
Copy link
Contributor

I'm not in favour of enabling tests due to the timeout

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Nov 8, 2018
@nswamy
Copy link
Member

nswamy commented Nov 8, 2018

I agree with @marcoabreu lets not add it to the branch

@lebeg
Copy link
Contributor Author

lebeg commented Nov 9, 2018

@marcoabreu @nswamy I think the timeout is not happening on the branch. Let's merge and observe, this will not harm, but in case it will work has the benefit to cover MacOS with testing.

@lebeg
Copy link
Contributor Author

lebeg commented Nov 10, 2018

@marcoabreu @nswamy You were right about the timeout, disabled the tests, but kept the build.

@@ -60,7 +60,7 @@ class LibraryInitializer {
// Make children single threaded since they are typically workers
dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1);
dmlc::SetEnv("OMP_NUM_THREADS", 1);
#if MXNET_USE_OPENCV
#if MXNET_USE_OPENCV && !__APPLE__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for not disabling opencv threads on mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KellenSunderland do you know why this is done? As said previously, my task here was to port commits from master to the release branch and make only necessary changes.

@nswamy
Copy link
Member

nswamy commented Nov 12, 2018

@lebeg I am not seeing a need for the OS X builds since the tests are disabled and also this did not exist for 1.3.0

@lebeg
Copy link
Contributor Author

lebeg commented Nov 12, 2018

@nswamy Ok, for clarity I understand this as: Strongly opposed to have it in the release branch. I'm not seeing that much risk as you do, but I commit to this decision and close this PR.

@lebeg lebeg closed this Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants