This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-908] Enable minimal OSX Travis build #12462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
approved these changes
Sep 5, 2018
#slack: dmlc:NmroCzntCiWOuxUZpii40USd | ||
- export MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0 | ||
- mv make/osx.mk config.mk | ||
- make -j 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the variable not available in Travis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referring to the magic '2' here, good point, I don't specify why that's required. I've updated with a comment that should provide some background.
marcoabreu
added
the
pr-awaiting-testing
PR is reviewed and waiting CI build and test
label
Sep 5, 2018
KellenSunderland
force-pushed
the
travis_ci
branch
from
September 5, 2018 12:24
51040d1
to
1f7e2e3
Compare
KellenSunderland
force-pushed
the
travis_ci
branch
from
September 5, 2018 12:28
1f7e2e3
to
750d454
Compare
Example build for this commit: https://travis-ci.org/KellenSunderland/incubator-mxnet/builds/424768656 |
@mxnet-label-bot can please add [pr-awaiting-review] |
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Sep 11, 2018
KellenSunderland
added a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Sep 15, 2018
KellenSunderland
added a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Sep 15, 2018
KellenSunderland
added a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Sep 15, 2018
KellenSunderland
added a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Sep 15, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Sep 19, 2018
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some legacy Travis code, and updates Travis to run cached MXNet builds on the platform. It is the first step in re-enabling MacOS testing. Subsequent PRs will enable testing (which will rely on builds first being cached). Subsequent PRs can also re-enable some of the features removed in this PR, for instance possible running more tests in addition to python tests, and re-enabling the model-download caching folder.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.