Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove fixed seed for test_sparse_nd_save_load #11920

Merged
merged 2 commits into from
Jul 28, 2018
Merged

Remove fixed seed for test_sparse_nd_save_load #11920

merged 2 commits into from
Jul 28, 2018

Conversation

kalyc
Copy link
Contributor

@kalyc kalyc commented Jul 27, 2018 •
edited
Loading

Description

Remove fixed seed for test_sparse_nd_save_load
Unable to reproduce flakiness of test - ran 10000 times

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Remove fixed seed for test_sparse_ndarray:test_sparse_nd_save_load

Comments

@haojin2 @szha

@kalyc kalyc mentioned this pull request Jul 27, 2018
Closed
@haojin2
Copy link
Contributor

haojin2 commented Jul 27, 2018

For this kind of case please refer my changes to #11888 and add the link to the tracking issue in the code so that we can backtrack if it happens to fail again.

szha
szha reviewed Jul 27, 2018
View reviewed changes
tests/python/unittest/test_sparse_ndarray.py
@with_seed(0)
# @kalyc: Getting rid of fixed seed as flakiness could not be reproduced
# tracked at https://github.com/apache/incubator-mxnet/issues/11741
@with_seed()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add comment if not flaky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments by @haojin2 above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@eric-haibin-lin eric-haibin-lin merged commit 011a0dc into apache:master Jul 28, 2018
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Aug 7, 2018
@anirudh2290 @aaronmarkham
Fix flaky test test_deconvolution (apache#11630)
4b3988e 
* Replace cublassgemm with cublassgemmex for >= 7.5

* Add comment for cublassgemmex

Remove fixed seed for test_sparse_nd_save_load (apache#11920)

* Remove fixed seed for test_sparse_nd_save_load

* Add comments related to the commit

Corrections to profiling tutorial (apache#11887)

Corrected a race condition with stopping profiling. Added mx.nd.waitall to ensure all operations have completed, including GPU operations that might otherwise be missing.

Also added alternative code for context selection GPU vs CPU, that had error before on machines with nvidia-smi.

Fix image classification scripts and Improve Fp16 tutorial (apache#11533)

* fix bugs and improve tutorial

* improve logging

* update benchmark_score

* Update float16.md

* update link to dmlc web data

* fix train cifar and add random mirroring

* set aug defaults

* fix whitespace

* fix typo
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@kalyc @eric-haibin-lin
Remove fixed seed for test_sparse_nd_save_load (apache#11920)
0fe3029 
* Remove fixed seed for test_sparse_nd_save_load

* Add comments related to the commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalyc @haojin2 @szha @eric-haibin-lin