Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_sparse_ndarray.test_sparse_nd_save_load has fixed seed that can mask flakiness #11741

Closed
szha opened this issue Jul 13, 2018 · 5 comments
Closed

test_sparse_ndarray.test_sparse_nd_save_load has fixed seed that can mask flakiness #11741

szha opened this issue Jul 13, 2018 · 5 comments
Labels
Flaky Test

Comments

@szha
Copy link
Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

  1. Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
  2. If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
  3. If numerical instability is inevitable, adjust tolerance level appropriately.
@apeforest
Copy link
Contributor

@szha Thanks for filing this issue. We will investigate these Flaky tests.

@apeforest
Copy link
Contributor

Thannks for filing this issue. We will investigate this Flaky test

@kalyc kalyc mentioned this issue Jul 27, 2018
Merged
6 tasks
@kalyc
Copy link
Contributor

kalyc commented Jul 27, 2018

Unable to reproduce issue with 10000 runs, opened PR - #11920

@kalyc
Copy link
Contributor

kalyc commented Jul 27, 2018

For reference, initially seed was set to 0

@kalyc
Copy link
Contributor

kalyc commented Jul 30, 2018

PR has been merged. @szha could you please close the issue?

@szha szha closed this as completed Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Flaky Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szha @apeforest @kalyc