Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Enable CUDNN for conv1D (#11194) #11270

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jun 14, 2018

original PR #11194

Description

Known issue: The CUDNN Convolution operator may throw CUDNN_STATUS_EXECUTION_FAILED when req == "add" and cudnn_tune != "off" with large inputs (e.g. 64K channels). If you encounter such error, please consider setting cudnn_tune to "off".

The above issue applies to both Conv1D and Conv2D, in both mxnet 1.1 and mxnet 1.2.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* enable cudnn for conv1d

* add checks for backward

* fix build

* fix build

* fix lint

* Update convolution.cc
@anirudh2290 anirudh2290 merged commit 73ebc76 into apache:v1.2.0 Jun 14, 2018
marcoabreu pushed a commit to marcoabreu/incubator-mxnet that referenced this pull request Jun 14, 2018
* enable cudnn for conv1d

* add checks for backward

* fix build

* fix build

* fix lint

* Update convolution.cc
marcoabreu pushed a commit that referenced this pull request Jun 14, 2018
* enable cudnn for conv1d

* add checks for backward

* fix build

* fix build

* fix lint

* Update convolution.cc
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Jun 15, 2018
* enable cudnn for conv1d

* add checks for backward

* fix build

* fix build

* fix lint

* Update convolution.cc
@eric-haibin-lin eric-haibin-lin deleted the v1.2.0 branch December 22, 2018 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants