This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Enable CUDNN for conv1D #11194
Merged
Enable CUDNN for conv1D #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zheng-da pls review |
safrooze
approved these changes
Jun 8, 2018
|
@eric-haibin-lin CI failed. Can you take a look? This is the error: |
zheng-da
reviewed
Jun 8, 2018
src/operator/nn/convolution.cc
Outdated
| std::vector<nnvm::NodeEntry> heads(ograds.begin(), ograds.end()); | ||
| heads.push_back(n->inputs[conv::kData]); | ||
| heads.push_back(n->inputs[conv::kWeight]); | ||
| if (!param.no_bias) | ||
| heads.push_back(n->inputs[conv::kBias]); |
There was a problem hiding this comment.
This is needed for MKLDNN.
There was a problem hiding this comment.
I missed some of the mkldnn code. reverted now.
zheng-da
approved these changes
Jun 8, 2018
eric-haibin-lin
added a commit
to eric-haibin-lin/mxnet
that referenced
this pull request
Jun 14, 2018
* enable cudnn for conv1d * add checks for backward * fix build * fix build * fix lint * Update convolution.cc
7 tasks
anirudh2290
pushed a commit
that referenced
this pull request
Jun 14, 2018
marcoabreu
pushed a commit
to marcoabreu/incubator-mxnet
that referenced
this pull request
Jun 14, 2018
* enable cudnn for conv1d * add checks for backward * fix build * fix build * fix lint * Update convolution.cc
marcoabreu
pushed a commit
that referenced
this pull request
Jun 14, 2018
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Jun 15, 2018
* enable cudnn for conv1d * add checks for backward * fix build * fix build * fix lint * Update convolution.cc
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* enable cudnn for conv1d * add checks for backward * fix build * fix build * fix lint * Update convolution.cc
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* enable cudnn for conv1d * add checks for backward * fix build * fix build * fix lint * Update convolution.cc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #9677 Conv1D is mistakenly switched from CUDNN implementation to MXNet implementation. This PR reverts the change.
This significantly improves operator speed, and reduce memory usage by half for some cases.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments