Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix list output names typo #10300

Merged
merged 2 commits into from
Mar 28, 2018

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented Mar 28, 2018

Description

  1. Fixed cosmetic issue of registering output names for convolution and fully_connected. Has no effect on the correctness since FListOutputNames and FListInputNames are identical functors.
  2. Added unit tests of output name check for convolution, fc, and lrn.

#10282
#10296

@piiswrong @zheng-da

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@reminisce reminisce requested a review from cjolivier01 as a code owner March 28, 2018 18:20
@piiswrong piiswrong merged commit 0ff490b into apache:master Mar 28, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
* Add unit test

* Add unit test
cjolivier01 pushed a commit to cjolivier01/mxnet that referenced this pull request Mar 30, 2018
haojin2 pushed a commit to haojin2/incubator-mxnet that referenced this pull request Apr 2, 2018
* Add unit test

* Add unit test
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Add unit test

* Add unit test
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Add unit test

* Add unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants