Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add more attributes in LRN #10296

Merged
merged 1 commit into from
Mar 28, 2018
Merged

add more attributes in LRN #10296

merged 1 commit into from
Mar 28, 2018

Conversation

zheng-da
Copy link
Contributor

Description

This is to address #10282

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zheng-da zheng-da requested a review from cjolivier01 as a code owner March 28, 2018 14:31
@piiswrong piiswrong merged commit 0d3ec94 into apache:master Mar 28, 2018
@reminisce
Copy link
Contributor

Please make sure unit test is added in the future. Otherwise, it may still slip through the attention if we refactor again in the future.

@reminisce reminisce mentioned this pull request Mar 28, 2018
5 tasks
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
cjolivier01 pushed a commit to cjolivier01/mxnet that referenced this pull request Mar 30, 2018
haojin2 pushed a commit to haojin2/incubator-mxnet that referenced this pull request Apr 2, 2018
@zheng-da zheng-da deleted the fix_LRN branch April 5, 2018 22:39
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da added a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants