[SUREFIRE-1914] Take displayName of container into account for XML reporting of @ParameterizedTest #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andpab
changed the title
|
@andpab |
|
CI build seems to have been successful. @Tibor17 What are the next steps? |
|
@andpab |
andpab
force-pushed
the
SUREFIRE-1914
branch
2 times, most recently
from
ca10152
to
4c3fa5c
Compare
…porting of @ParameterizedTest
andpab
changed the title
|
Rebased to upstream master and squashed the two commits. |
|
@andpab |
|
@andpab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress. It does the job, but may not be the best or most appropriate way to do it.
I'm not particularly happy with the !display.startsWith( "[" ) in the needsSpaceSeparator condition in particular.