[SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs #351
Conversation
| + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" ) | ||
| .assertContainsText( "<testcase name=\"1 + 2 = 3\" " |
There was a problem hiding this comment.
Where is the old method? I cannot see it here in this PR.
I would like to keep it and add new ones because then we have more alternatives. Would it be possible?
Pls check our documentation because sometimes we use the reference pointing to our IT tests.
There was a problem hiding this comment.
I will rewrite the PR, so that it does not change existing ITs. Thanks for your feedback.
There was a problem hiding this comment.
Rewrote it, so that only a new dedicated test project and IT for it is added.
Test project: surefire-1914-xml-reporting-parameterizedtest
IT: Surefire1914XmlReportingParameterizedTestIT.java
Please have a look again.
For reference: The relevant pre-existing IT with a divergent expectation is JUnitPlatformEnginesIT#testJupiterEngineWithDisplayNames
| </plugins> | ||
| </build> | ||
|
|
||
| <repositories> |
There was a problem hiding this comment.
Pls remove the repository. Our build uses the artifacts from your local repo. It means the integration tests expect mvn install which packages and installs the project artifacts in your local repo on your disk. Pls run
mvn install -DskipTests
mvn verify -rf :surefire-its -nsu -P run-its -Dit.test=Surefire1914XmlReportingParameterizedTestIT
There was a problem hiding this comment.
Removed the repository definition.
There was a problem hiding this comment.
ok, I am trying to build your project.
There was a problem hiding this comment.
@Tibor17 I noticed there were still a couple of inconsistencies in my expectations. I force-pushed some changes. Please checkout anew.
|
@andpab |
…rameterizedTest with ITs
|
Ok, I've given it a shot. Opened a second draft PR: #352 Please give me some feedback. |
This is just a draft to document what my expectations - as also described in the issue - would be. Obviously that means some tests will fail.
This draft is meant to form a basis for discussion, not to be merged directly.