Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NET45, NET451, NET452 Support & update website framework ver #650

Merged
merged 2 commits into from
Oct 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Generate-TestWorkflows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ param(

[string]$RepoRoot = (Split-Path (Split-Path $PSScriptRoot)),

[string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), # targets under test: net6.0, netstandard2.1, netstanard2.0, net45
[string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), # targets under test: net6.0, netstandard2.1, netstanard2.0, net48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framework under test in this case would be net462


[string[]]$OperatingSystems = @('windows-latest', 'ubuntu-latest'),

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-AllProjects.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-Common.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-Kuromoji.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-Morfologik.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-OpenNLP.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-Phonetic.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-SmartCn.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Analysis-Stempel.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Benchmark.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Classification.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Cli.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-CodeAnalysis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Codecs.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Demo.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Expressions.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Facet.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Grouping.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Highlighter.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-ICU.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Join.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Memory.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Misc.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Queries.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-QueryParser.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Replicator.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Sandbox.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Spatial.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-Suggest.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-TestFramework.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-_A-D.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-_E-I.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-_I-J.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-_J-S.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Lucene-Net-Tests-_T-Z.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
####################################################################################
####################################################################################
# DO NOT EDIT: This file was automatically generated by Generate-TestWorkflows.ps1
####################################################################################
# Licensed to the Apache Software Foundation (ASF) under one
Expand Down
2 changes: 1 addition & 1 deletion Lucene.Net.sln
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lucene.Net.Tests.AllProject
EndProject
Project("{E24C65DC-7377-472B-9ABA-BC803B73C61A}") = "websites", "websites\", "{8988CDA4-8420-4BEE-869A-66825055EED2}"
ProjectSection(WebsiteProperties) = preProject
TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.0"
TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.6.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue only affects contributors who open the project in Visual Studio 2022. We should probably just bump this to 4.8, since that framework is more likely to be installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought the same thing but then resolved that that chasing the latest version doesn't make sense. Further, the solution produces Framework 4.6.2 assemblies and 4.6.2 is not yet depreciated, so I decided it made more sense to use 4.6.2 for the website project.

Debug.AspNetCompiler.VirtualPath = "/localhost_59352"
Debug.AspNetCompiler.PhysicalPath = "websites\"
Debug.AspNetCompiler.TargetPath = "PrecompiledWeb\localhost_59352\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.Common</AssemblyTitle>
<PackageTags>$(PackageTags);analysis</PackageTags>
Expand All @@ -50,7 +50,7 @@
<ProjectReference Include="..\Lucene.Net\Lucene.Net.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
<Reference Include="System.Xml" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.Kuromoji</AssemblyTitle>
<PackageTags>$(PackageTags);analysis;japanese</PackageTags>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net451</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.Morfologik</AssemblyTitle>
<RootNamespace>Lucene.Net.Analysis</RootNamespace>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFramework>net451</TargetFramework>
<TargetFramework>net462</TargetFramework>

<AssemblyTitle>Lucene.Net.Analysis.OpenNLP</AssemblyTitle>
<PackageTags>$(PackageTags);analysis;natural;language;processing;opennlp</PackageTags>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.Phonetic</AssemblyTitle>
<PackageTags>$(PackageTags);analysis;soundex;double;metaphone;sounds;like;beider;morse;cologne;caverphone;nysiis;match;rating</PackageTags>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net451</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.SmartCn</AssemblyTitle>
<PackageTags>$(PackageTags);analysis;chinese;smart</PackageTags>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Analysis.Stempel</AssemblyTitle>
<PackageTags>$(PackageTags);analysis;polish</PackageTags>
Expand Down
4 changes: 2 additions & 2 deletions src/Lucene.Net.Benchmark/Lucene.Net.Benchmark.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net451</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Benchmark</AssemblyTitle>
<PackageTags>$(PackageTags);benchmark</PackageTags>
Expand Down Expand Up @@ -69,7 +69,7 @@
<PackageReference Include="SharpZipLib" Version="$(SharpZipLibPackageVersion)" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
<PackageReference Include="SharpZipLib" Version="$(SharpZipLibPackageVersion)" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Classification</AssemblyTitle>
<PackageTags>$(PackageTags);classification</PackageTags>
Expand Down
2 changes: 1 addition & 1 deletion src/Lucene.Net.Codecs/Lucene.Net.Codecs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<Import Project="$(SolutionDir).build/nuget.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net45</TargetFrameworks>
<TargetFrameworks>net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks>

<AssemblyTitle>Lucene.Net.Codecs</AssemblyTitle>
<PackageTags>$(PackageTags);codec</PackageTags>
Expand Down
Loading