-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NET45, NET451, NET452 Support & update website framework ver #650
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -263,7 +263,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lucene.Net.Tests.AllProject | |
EndProject | ||
Project("{E24C65DC-7377-472B-9ABA-BC803B73C61A}") = "websites", "websites\", "{8988CDA4-8420-4BEE-869A-66825055EED2}" | ||
ProjectSection(WebsiteProperties) = preProject | ||
TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.0" | ||
TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.6.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This issue only affects contributors who open the project in Visual Studio 2022. We should probably just bump this to 4.8, since that framework is more likely to be installed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Initially I thought the same thing but then resolved that that chasing the latest version doesn't make sense. Further, the solution produces Framework 4.6.2 assemblies and 4.6.2 is not yet depreciated, so I decided it made more sense to use 4.6.2 for the website project. |
||
Debug.AspNetCompiler.VirtualPath = "/localhost_59352" | ||
Debug.AspNetCompiler.PhysicalPath = "websites\" | ||
Debug.AspNetCompiler.TargetPath = "PrecompiledWeb\localhost_59352\" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The framework under test in this case would be net462