Remove NET45, NET451, NET452 Support & update website framework ver #650
Conversation
rclabo
changed the title
rclabo
changed the title
| @@ -65,7 +65,7 @@ param( | |||
|
|
|||
| [string]$RepoRoot = (Split-Path (Split-Path $PSScriptRoot)), | |||
|
|
|||
| [string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), # targets under test: net6.0, netstandard2.1, netstanard2.0, net45 | |||
| [string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), # targets under test: net6.0, netstandard2.1, netstanard2.0, net48 | |||
There was a problem hiding this comment.
The framework under test in this case would be net462
| @@ -263,7 +263,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lucene.Net.Tests.AllProject | |||
| EndProject | |||
| Project("{E24C65DC-7377-472B-9ABA-BC803B73C61A}") = "websites", "websites\", "{8988CDA4-8420-4BEE-869A-66825055EED2}" | |||
| ProjectSection(WebsiteProperties) = preProject | |||
| TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.0" | |||
| TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.6.2" | |||
There was a problem hiding this comment.
This issue only affects contributors who open the project in Visual Studio 2022. We should probably just bump this to 4.8, since that framework is more likely to be installed.
There was a problem hiding this comment.
Initially I thought the same thing but then resolved that that chasing the latest version doesn't make sense. Further, the solution produces Framework 4.6.2 assemblies and 4.6.2 is not yet depreciated, so I decided it made more sense to use 4.6.2 for the website project.
|
@NightOwl888 @rclabo I've noticed that the only project still targeting a lower version than As every project was updated to |
|
@nikcio I initially planned to remove Net461 and ran into a snag. It turns out that to support one of the NetStandard targets we use Net461 for that build and more importantly need it to be a different framework version then any other build so that we can sense that NetStandand build by triggering on the targeted framework. Doing something different was a bit of a rathole so I left it. |
|
@nikcio - Thanks for pointing that out. I just opened #747, since there is quite a bit to figuring out what to target and whether or not we need another package to include extension methods for wiring this up in AspNetCore across .NET Core and .NET Framework. This is one of the few areas in the project that could be considered "new" development. I suspect that |
+Removed NET45, NET451, and NET452 support. These are no longer supported by Microsoft.
+Changed the website project from Framework 4.0 to Framework 4.6.2 to allow for easier loading in VS2022.