LUCENE-9555: Advance conjuction Iterator for two phase iteration

[mayya-sharipova]

PR #1351 introduced a sort optimization where
documents can be skipped.
But there was a bug in case we were using two phase
approximation, as we would advance it without advancing
an overall conjunction iterator.

This patch fixed it.

Relates to #1351

[mayya-sharipova]

This patch also addresses the failure of TestUnifiedHighlighterStrictPhrases.testBasics.
This test was using ReqExclBulkScorer that lead to scorerIterator being already on max document when we were trying to make a conjunction between scorerIterator and collectorIterator.

[jpountz]

It's a pity to disable this great optimization when scoring ranges of doc IDs versus scoring the entire doc ID space at once. Maybe we can apply the leap-frog logic without using ConjunctionDISI in that method, or alternatively wrap the scorer DISI in a way that makes usage of ConjunctionDISI legal?

class RangeDISIWrapper {

  private final DocIdSetIterator in;
  private final int min, max;
  private int doc = -1;

  @Override
  public int advance(int target) {
    target = Math.max(min, target);
    if (target >= max) {
      return NO_MORE_DOCS;
    }
    return doc = in.advance(target);
  }

}

[mayya-sharipova]

@jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it.
Basically this PR will just address the failing test of TestUnifiedHighlighterStrictPhrases.testBasics.

My next steps will the following:
Plan A:

• use leap-frog logic without using ConjunctionDISI for this method (a separate PR for that)
• Then reintroduce again checks in ConjunctionDISI that I reverted

Plan B:

• continue to use ConjunctionDISI to combine scorerIterator and collectorIterator
• from checks in ConjunctionDISI keep only the check of subiterators the same doc during constructor and remove all other checks, as sort optimization by introducing new DISI (from -1 doc) in the middle of iteration would break these checks.

I am interested in your opinion which plan is better?