Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance conjunction Iterator for two phase iteration [LUCENE-9555] #10594

Open
asfimport opened this issue Oct 2, 2020 · 2 comments
Open

Advance conjunction Iterator for two phase iteration [LUCENE-9555] #10594

asfimport opened this issue Oct 2, 2020 · 2 comments

Comments

@asfimport
Copy link

asfimport commented Oct 2, 2020

#10320 introduced a sort optimization where
documents can be skipped.
But there was a bug in case we were using two phase
approximation, as we would advance it without advancing
an overall conjunction iterator.

Relates to #10320


Migrated from LUCENE-9555 by Mayya Sharipova (@mayya-sharipova), updated Oct 06 2020
Pull requests: apache/lucene-solr#1943

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 6ac94a6 in lucene-solr's branch refs/heads/master from Mayya Sharipova
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6ac94a6

LUCENE-9555: Advance conjunction Iterator for two phase iteration (#1943)

PR #1351 introduced a sort optimization where
documents can be skipped.
But there was a bug in case we were using two phase
approximation, as we would advance it without advancing
an overall conjunction iterator.

This patch fixed it.

Relates to #1351

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit e7bf2dc in lucene-solr's branch refs/heads/branch_8x from Mayya Sharipova
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e7bf2dc

LUCENE-9555: Advance conjunction Iterator for two phase iteration (#1943)

PR #1351 introduced a sort optimization where
documents can be skipped.
But there was a bug in case we were using two phase
approximation, as we would advance it without advancing
an overall conjunction iterator.

This patch fixed it.

Relates to #1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant