Tolerate exceptions for periodical scheduled tasks #5730

bowenliang123 · 2023-11-20T06:32:49Z

🔍 Description

Issue References 🔗

As the PR #5727 fixed a problem caused by leaking exception in a scheduled task, the exception thrown should be properly handled to prevent suspension in ScheduledExecutorService.scheduleWithFixedDelay.

Describe Your Solution 🔧

Introducing a util method scheduleTolerableRunnableWithFixedDelay for catching possible exceptions in scheduled tasks.

Types of changes 🔖

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

No behaviour change.

Behavior With This Pull Request 🎉

This is a fallback measure to ensure all the exceptions handled.
Currently all the occurrences are properly handled.

Related Unit Tests

Pass all the CI tests.

Checklists

📝 Author Self Checklist

My code follows the style guidelines of this project
I have performed a self-review
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

Be nice. Be informative.

codecov-commenter · 2023-11-20T08:07:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71b0376) 61.38% compared to head (a38eda0) 61.38%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5730      +/-   ##
============================================
- Coverage     61.38%   61.38%   -0.01%     
  Complexity       23       23              
============================================
  Files           607      607              
  Lines         35836    35882      +46     
  Branches       4917     4920       +3     
============================================
+ Hits          21998    22025      +27     
- Misses        11457    11475      +18     
- Partials       2381     2382       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bowenliang123 · 2023-11-20T08:08:48Z

cc @turboFei @wForget

kyuubi-common/src/main/scala/org/apache/kyuubi/util/ThreadUtils.scala

# 🔍 Description ## Issue References 🔗 As the PR #5727 fixed a problem caused by leaking exception in a scheduled task, the exception thrown should be properly handled to prevent suspension in `ScheduledExecutorService.scheduleWithFixedDelay`. ## Describe Your Solution 🔧 Introducing a util method `scheduleTolerableRunnableWithFixedDelay` for catching possible exceptions in scheduled tasks. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ No behaviour change. #### Behavior With This Pull Request 🎉 This is a fallback measure to ensure all the exceptions handled. Currently all the occurrences are properly handled. #### Related Unit Tests Pass all the CI tests. --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5730 from bowenliang123/tolerate-runnable. Closes #5730 a38eda0 [Bowen Liang] use thread name for error message 6bc13b7 [Bowen Liang] comment 87e2bf2 [Bowen Liang] schedule tolerable runnable Authored-by: Bowen Liang <[email protected]> Signed-off-by: fwang12 <[email protected]> (cherry picked from commit 8480605) Signed-off-by: fwang12 <[email protected]>

turboFei · 2023-11-20T12:37:17Z

thanks, merged to master and branch-1.8

…se notes # 🔍 Description ## Issue References 🔗 Currently, we use a rather primitive way to manually write release notes from scratch, and some of the mechanical and repetitive work can be simplified by the scripts. ## Describe Your Solution 🔧 Adds a script to simplify the process of creating release notes. Note: it just simplifies some processes, the release manager still needs to tune the outputs by hand. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 ``` RELEASE_TAG=v1.8.1 PREVIOUS_RELEASE_TAG=v1.8.0 build/release/pre_gen_release_notes.py ``` ``` $ head build/release/commits-v1.8.1.txt [KYUUBI #5981] Deploy Spark Hive connector with Scala 2.13 to Maven Central [KYUUBI #6058] Make Jetty server stop timeout configurable [KYUUBI #5952][1.8] Disconnect connections without running operations after engine maxlife time graceful period [KYUUBI #6048] Assign serviceNode and add volatile for variables [KYUUBI #5991] Error on reading Atlas properties composed of multi values [KYUUBI #6045] [REST] Sync the AdminRestApi with the AdminResource Apis [KYUUBI #6047] [CI] Free up disk space [KYUUBI #6036] JDBC driver conditional sets fetchSize on opening session [KYUUBI #6028] Exited spark-submit process should not block batch submit queue [KYUUBI #6018] Speed up GetTables operation for Spark session catalog ``` ``` $ head build/release/contributors-v1.8.1.txt * Shaoyun Chen -- [KYUUBI #5857][KYUUBI #5720][KYUUBI #5785][KYUUBI #5617] * Chao Chen -- [KYUUBI #5750] * Flyangz -- [KYUUBI #5832] * Pengqi Li -- [KYUUBI #5713] * Bowen Liang -- [KYUUBI #5730][KYUUBI #5802][KYUUBI #5767][KYUUBI #5831][KYUUBI #5801][KYUUBI #5754][KYUUBI #5626][KYUUBI #5811][KYUUBI #5853][KYUUBI #5765] * Paul Lin -- [KYUUBI #5799][KYUUBI #5814] * Senmiao Liu -- [KYUUBI #5969][KYUUBI #5244] * Xiao Liu -- [KYUUBI #5962] * Peiyue Liu -- [KYUUBI #5331] * Junjie Ma -- [KYUUBI #5789] ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6074 from pan3793/release-script. Closes #6074 3d5ec20 [Cheng Pan] credits 1765279 [Cheng Pan] Add a script to simplify the process of creating release notes Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>

… release notes # 🔍 Description ## Issue References 🔗 Currently, we use a rather primitive way to manually write release notes from scratch, and some of the mechanical and repetitive work can be simplified by the scripts. ## Describe Your Solution 🔧 Adds a script to simplify the process of creating release notes. Note: it just simplifies some processes, the release manager still needs to tune the outputs by hand. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 ``` RELEASE_TAG=v1.8.1 PREVIOUS_RELEASE_TAG=v1.8.0 build/release/pre_gen_release_notes.py ``` ``` $ head build/release/commits-v1.8.1.txt [KYUUBI apache#5981] Deploy Spark Hive connector with Scala 2.13 to Maven Central [KYUUBI apache#6058] Make Jetty server stop timeout configurable [KYUUBI apache#5952][1.8] Disconnect connections without running operations after engine maxlife time graceful period [KYUUBI apache#6048] Assign serviceNode and add volatile for variables [KYUUBI apache#5991] Error on reading Atlas properties composed of multi values [KYUUBI apache#6045] [REST] Sync the AdminRestApi with the AdminResource Apis [KYUUBI apache#6047] [CI] Free up disk space [KYUUBI apache#6036] JDBC driver conditional sets fetchSize on opening session [KYUUBI apache#6028] Exited spark-submit process should not block batch submit queue [KYUUBI apache#6018] Speed up GetTables operation for Spark session catalog ``` ``` $ head build/release/contributors-v1.8.1.txt * Shaoyun Chen -- [KYUUBI apache#5857][KYUUBI apache#5720][KYUUBI apache#5785][KYUUBI apache#5617] * Chao Chen -- [KYUUBI apache#5750] * Flyangz -- [KYUUBI apache#5832] * Pengqi Li -- [KYUUBI apache#5713] * Bowen Liang -- [KYUUBI apache#5730][KYUUBI apache#5802][KYUUBI apache#5767][KYUUBI apache#5831][KYUUBI apache#5801][KYUUBI apache#5754][KYUUBI apache#5626][KYUUBI apache#5811][KYUUBI apache#5853][KYUUBI apache#5765] * Paul Lin -- [KYUUBI apache#5799][KYUUBI apache#5814] * Senmiao Liu -- [KYUUBI apache#5969][KYUUBI apache#5244] * Xiao Liu -- [KYUUBI apache#5962] * Peiyue Liu -- [KYUUBI apache#5331] * Junjie Ma -- [KYUUBI apache#5789] ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6074 from pan3793/release-script. Closes apache#6074 3d5ec20 [Cheng Pan] credits 1765279 [Cheng Pan] Add a script to simplify the process of creating release notes Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>

github-actions bot added module:server module:spark module:common labels Nov 20, 2023

schedule tolerable runnable

87e2bf2

bowenliang123 force-pushed the tolerate-runnable branch from 7d2c5fd to 87e2bf2 Compare November 20, 2023 06:51

bowenliang123 marked this pull request as ready for review November 20, 2023 06:53

bowenliang123 changed the title ~~Tolerate execeptions in scheduled tasks for ScheduledExecutorService~~ Tolerate execeptions for periodical scheduled tasks Nov 20, 2023

turboFei reviewed Nov 20, 2023

View reviewed changes

kyuubi-common/src/main/scala/org/apache/kyuubi/util/ThreadUtils.scala Outdated Show resolved Hide resolved

bowenliang123 added 2 commits November 20, 2023 17:13

comment

6bc13b7

use thread name for error message

a38eda0

turboFei approved these changes Nov 20, 2023

View reviewed changes

turboFei requested a review from pan3793 November 20, 2023 09:47

turboFei assigned bowenliang123 Nov 20, 2023

turboFei added this to the v1.9.0 milestone Nov 20, 2023

turboFei closed this in 8480605 Nov 20, 2023

turboFei modified the milestones: v1.9.0, v1.8.1 Nov 20, 2023

bowenliang123 changed the title ~~Tolerate execeptions for periodical scheduled tasks~~ Tolerate exceptions for periodical scheduled tasks Nov 21, 2023

bowenliang123 deleted the tolerate-runnable branch November 21, 2023 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tolerate exceptions for periodical scheduled tasks #5730

Tolerate exceptions for periodical scheduled tasks #5730

bowenliang123 commented Nov 20, 2023 •

edited

Loading

codecov-commenter commented Nov 20, 2023 •

edited

Loading

bowenliang123 commented Nov 20, 2023

turboFei commented Nov 20, 2023

Tolerate exceptions for periodical scheduled tasks #5730

Tolerate exceptions for periodical scheduled tasks #5730

Conversation

bowenliang123 commented Nov 20, 2023 • edited Loading

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Types of changes 🔖

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklists

📝 Author Self Checklist

📝 Committer Pre-Merge Checklist

codecov-commenter commented Nov 20, 2023 • edited Loading

Codecov Report

bowenliang123 commented Nov 20, 2023

turboFei commented Nov 20, 2023

bowenliang123 commented Nov 20, 2023 •

edited

Loading

codecov-commenter commented Nov 20, 2023 •

edited

Loading