Rebase postgres on master #2497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generate a unique UUID so this is supported. Note that turns 5 tests on in the PostgresMailboxManager test suite.
- Use single query to database for fetch total + total unseen The query looks like: select count(*) as "total_count", count(*) filter (where is_seen = $1) as "unseen_count" from message_mailbox where mailbox_id = cast($2 as uuid)
- It is a why make lack of test case when run the test (jpaGuiceServerShouldUpdateQuota)
…ase sql validation - It was created for JPA, with Postgresql we don't need it. (instead of mark @disabled for it)
Fixed by JAMES-2586 Small codestyle refactorings.
…lict Otherwise, we could retry on other fatal errors like: io.r2dbc.postgresql.ExceptionFactory$PostgresqlBadGrammarException: column "domain" of relation "mailbox" already exists.
…olicy before alter the table
This prevents data loss.
Co-authored-by: Quan Tran <[email protected]>
Co-authored-by: Quan Tran <[email protected]>
…ds documentation page
…-cli GIVEN I run james-cli in kubernetes THEN the pod crashes and reboots Because the james-cli runs JVM it catches the environment variables set by James. As such it always pretouch 3GB of RAM. When added to memory consumed by James it exceeds the limit and pod get's OOM-killed.
- Ref commit: 829a63f [IMPROVEMENT] JMAP use search index relevance as default sort
…Supported - TODO - Wait to adapt James-3945 to Postgres Ref commit: 81b61ed
- Fix java.util.ConcurrentModificationException - Fix test InMemoryUploadRepositoryTest
|
We just rebased it 2 weeks ago (#2467) I think there aren’t too many changes to require doing this frequently (since the number of files changed is very large) We could simply cherry-pick the new commits |
hungphan227
force-pushed
the
Rebase-postgres-on-master
branch
from
a7aeb59 to
ea1daa5
Compare
…g errors This would ease linking and identifying IMAP parsing issues
hungphan227
force-pushed
the
Rebase-postgres-on-master
branch
from
ea1daa5 to
105a0ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.